Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76146

Move grade actions (hide, show, lock, grade analysis) to dropdown menu in the Grader report table

    XMLWordPrintable

Details

    • MOODLE_402_STABLE
    • MOODLE_402_STABLE
    • MDL-76146-master
    • Hide
      1. On admin/settings.php?section=gradereportgrader page ensure there is no 'Show show/hide icons' setting
      2. On admin/settings.php?section=gradereportgrader page ensure there is no 'Show locks' setting
      3. On admin/settings.php?section=gradereportgrader page ensure there is no 'Show grade analysis icon' setting
      4. On admin/settings.php?section=gradereportgrader page ensure there is no 'Enable AJAX' setting
      5. On admin/settings.php?section=gradereportgrader page ensure there is no 'Quick feedback' setting
      6. Create a course
      7. Enrol some users with Student role and also 2 users with role Teacher and Non-Editing Teacher
      8. Remove 'moodle/grade:viewhidden' for Non-Editing Teacher role
      9. On course grader report prefercences page ensure there is no 'Show quick feedback' setting
      10. On course grader report prefercences page ensure there is no 'Ajax grading' setting
      11. On course grader report prefercences page ensure there is no 'Show show/hide icons' setting
      12. On course grader report prefercences page ensure there is no 'Show locks' setting
      13. On course grader report prefercences page ensure there is no 'Show grade analysis icon' setting
      14. Create quiz and assignment
      15. Create another assignment with 'gradetopass' set to some number (like 50)
      16. Create manual grade item on gradebook setup page with grade of type scale
      17. Create manual grade item on gradebook setup page with grade of type value
      18. In admin/settings.php?section=gradessettings set 'Show submitted date for hidden grades' to ticked
      19. Give users some grades (via assignment/quiz grade interface).
      20. Go to grader report page with editing off
      21. Ensure that only cells for QUIZ grades have more menu with only one option 'Grade analysis'. Ensure clicking on it brings you to quiz grade analysis page
      22. Ensure other grade cells have no 'more' menu
      23. Ensure no cell has any status icon by default (i.e. no lock icon, override icon etc)
      24. Turn editing on
      25. Ensure that each grade cell have 'more' menu with following options: Edit grade, Hide, Lock. Quiz grade cells should also have 'Grade analysis' option
      26. Ensure that 'Edit grade' option leads you to advanced grade edit page.
      27. On advanced grade edit page check 'Excluded', 'Hidden' and 'Locked' checkbox and Save changes
      28. On grader report page ensure that associated grade have status exluded, hidden and locked icons. Each icon should have relevant tooltip.
      29. Edit some grades on grader report page and click Save changes.
      30. Ensure that edited grade have overriden status icon with a tooltip
      31. Play with action menu 'hide', 'show' for grades and ensure grade has correct status and options are changing accordingly (i.e. if item is hidden, action menu should have Show option, similar to locked)
      32. Hide a whole grade item
      33. Ensure that all grades for that grade item are now hidden (all have cross eye icon). Ensure that option 'Show' is grayed out in grade action dropdown and on hover on that option you can see a tooltip with the reason why option is not available
      34. Lock a whole grade item
      35. Ensure that all grades for that grade item are now locked (all have lock icon and cell is not editable). Ensure that option 'Unlock' is grayed out in grade action dropdown and on hover on that option you can see a tooltip with the reason why option is not available
      Show
      On admin/settings.php?section=gradereportgrader page ensure there is no 'Show show/hide icons' setting On admin/settings.php?section=gradereportgrader page ensure there is no 'Show locks' setting On admin/settings.php?section=gradereportgrader page ensure there is no 'Show grade analysis icon' setting On admin/settings.php?section=gradereportgrader page ensure there is no 'Enable AJAX' setting On admin/settings.php?section=gradereportgrader page ensure there is no 'Quick feedback' setting Create a course Enrol some users with Student role and also 2 users with role Teacher and Non-Editing Teacher Remove 'moodle/grade:viewhidden' for Non-Editing Teacher role On course grader report prefercences page ensure there is no 'Show quick feedback' setting On course grader report prefercences page ensure there is no 'Ajax grading' setting On course grader report prefercences page ensure there is no 'Show show/hide icons' setting On course grader report prefercences page ensure there is no 'Show locks' setting On course grader report prefercences page ensure there is no 'Show grade analysis icon' setting Create quiz and assignment Create another assignment with 'gradetopass' set to some number (like 50) Create manual grade item on gradebook setup page with grade of type scale Create manual grade item on gradebook setup page with grade of type value In admin/settings.php?section=gradessettings set 'Show submitted date for hidden grades' to ticked Give users some grades (via assignment/quiz grade interface). Go to grader report page with editing off Ensure that only cells for QUIZ grades have more menu with only one option 'Grade analysis'. Ensure clicking on it brings you to quiz grade analysis page Ensure other grade cells have no 'more' menu Ensure no cell has any status icon by default (i.e. no lock icon, override icon etc) Turn editing on Ensure that each grade cell have 'more' menu with following options: Edit grade, Hide, Lock. Quiz grade cells should also have 'Grade analysis' option Ensure that 'Edit grade' option leads you to advanced grade edit page. On advanced grade edit page check 'Excluded', 'Hidden' and 'Locked' checkbox and Save changes On grader report page ensure that associated grade have status exluded, hidden and locked icons. Each icon should have relevant tooltip. Edit some grades on grader report page and click Save changes. Ensure that edited grade have overriden status icon with a tooltip Play with action menu 'hide', 'show' for grades and ensure grade has correct status and options are changing accordingly (i.e. if item is hidden, action menu should have Show option, similar to locked) Hide a whole grade item Ensure that all grades for that grade item are now hidden (all have cross eye icon). Ensure that option 'Show' is grayed out in grade action dropdown and on hover on that option you can see a tooltip with the reason why option is not available Lock a whole grade item Ensure that all grades for that grade item are now locked (all have lock icon and cell is not editable). Ensure that option 'Unlock' is grayed out in grade action dropdown and on hover on that option you can see a tooltip with the reason why option is not available
    • 10
    • HQ Team Alpha - Sprint 1.1, HQ Team Alpha - Sprint 1.2, HQ Team Alpha - Sprint 1.3, Team Alpha - Sprint 2

    Description

      Summary:

      Based on the figma prototype the aim of this issue is to implement a new "caret" dropdown menu that contains all present actions available in edit mode for each grade in the Grader report table. The goal of this change is to de-clutter the Grader report and reduce the cognitive load.

      Attached screenshots show same pages before and after changes with editing on/off

      Scope:

      1. Deprecate quick feedback from grader report (feedback can contain html tags and current cell is too small to display even short sentences, doesn't really work for scales at all)
      2. Deprecate AJAX interface for grader report (It is confusing, also not great in terms of recalculation - like averages are computed every time we click away of cell etc)
        1. Send notification on upgrade to admins of sites which had the AJAX interface enabled in the grader report.
      3. Implement new "caret" dropdown menu for each grade item available only in edit mode (each item to substitute existing action icons).
      4. The dropdown should contain the following options:
        1. Settings (Grade settings)
        2. View/Hide (Toggle grade visibility)
        3. Lock (Grade locking)
      5. Remove settings 'Show show/hide icons', 'Show locks', 'Show grade analysis icon' - those are going to be always show in new action menu and since they are in menu - it won't clutter page as old action icons
      6. Remove confusing color legend for overridden grades (state will be shown as status icon). Currently overriden grade is shown as brown color background. Its not accessible and user has no hint
      7. Remove ''excluded' text for excluded grade (state will be shown as status icon) - it clutters space and also can be long depending on language. We will show excluded state with respective icon with a tooltip instead
      8. Implement reasonable automated testing.

      Attachments

        1. (I) Passed -- (Master)MDL-76146.png
          (I) Passed -- (Master)MDL-76146.png
          105 kB
        2. 1.png
          1.png
          19 kB
        3. afterpatch-editing-off.png
          afterpatch-editing-off.png
          42 kB
        4. afterpatch-editing-on.png
          afterpatch-editing-on.png
          66 kB
        5. beforepatch-editing-off.png
          beforepatch-editing-off.png
          34 kB
        6. beforepatch-editing-on.png
          beforepatch-editing-on.png
          75 kB
        7. Screenshot from 2022-11-21 14-55-48.png
          Screenshot from 2022-11-21 14-55-48.png
          27 kB

        Issue Links

          Activity

            People

              ilyatregubov Ilya Tregubov
              Geshoski Mihail Geshoski
              Mihail Geshoski Mihail Geshoski
              Paul Holden Paul Holden
              Kim Jared Lucas Kim Jared Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 1 week Original Estimate - 1 week
                  1w
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 weeks, 2 days, 3 minutes
                  3w 2d 3m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.