Loading...

XML

Word

Printable

Affected Branches:
MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Pull from Repository:
https://github.com/davewoloszyn/moodle.git
Pull Main Branch:
~~MDL-76167~~-master
Pull Main Diff URL:
https://github.com/davewoloszyn/moodle/compare/720bd60fc6...MDL-76167-master
Testing Instructions:
Hide

Requirements

IDE of choice with docblock code linting on

Instructions

Using your IDE, open file installlib.php

Locate function called install_print_header

CONFIRM when $config is being used that there are no code linting errors

Locate function called install_print_footer

CONFIRM when $config is being used that there are no code linting errors
Show
Requirements IDE of choice with docblock code linting on Instructions Using your IDE, open file installlib.php Locate function called install_print_header CONFIRM when $config is being used that there are no code linting errors Locate function called install_print_footer CONFIRM when $config is being used that there are no code linting errors

Found a couple of functions with incorrect docblock param type declarations in installlib.php.

install_print_header and install_print_footer are incorrectly docblocked as arrays. Should be object.

Discovered while testing

MDL-76130 Button's position on Web Install pages

Participants:: Angelia Dela Cruz, CiBoT, David Woloszyn, Huong Nguyen, Paul Holden, Sara Arjona (@sarjona)

Estimated:

Not Specified

Remaining:

Logged:

58m