Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76169

Various behat fixes for Question

    XMLWordPrintable

Details

    Description

      As discovered in MDL-74035 we have a lot of issues we need to solve before that issue can land, specifically:

      • action menu steps suck and need serious improvement to be usable in tables, this includes:
        • making steps which specifically target an action menu
        • making steps which work both with, and without, JavaScript
      • new behat steps introduced as part of the question engine changes in 4.0 are full of problems that need to be fixed, including:
        • many steps which do things like checking that the word "Delete" is present somewhere on the page
        • use of CSS selectors
        • use of steps which are too broad and therefore click on the wrong link
        • setting checkboxes wth a click instead of the set field
        • over-use of the javascript tag without any need
      • The "I should see :x in :y" step has an issue with accepting NodeElements

      These are all easy to solve, and mostly block 74035, but most should also be backported as is our ruling with Behat fixes hence the separate issue.

      All branches will get the new Action menu steps, and the change to the shoudl see steps.
      Only 400 and master get the changes to the questino bank tests.

      Attachments

        Issue Links

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Safat Shahin Safat Shahin
              Sara Arjona (@sarjona) Sara Arjona (@sarjona)
              CiBoT CiBoT
              Safat Shahin, Tim Hunt, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Nov/22

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 11 minutes
                  3h 11m