[MDL-76179] Don't send 'import' value as action parameter to preset.php file if is not allowed - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 4.1
Fix Version/s: 4.1
Component/s: Database activity module
Labels:

Affected Branches:
MOODLE_401_STABLE
Fixed Branches:
MOODLE_401_STABLE
Epic Link:
Moodle 4.1 Database project
Pull from Repository:
https://github.com/aanabit/moodle.git
Pull Master Branch:
~~MDL-76179~~-master
Pull Master Diff URL:
https://github.com/aanabit/moodle/compare/MDL-76179-master~...MDL-76179-master
Testing Instructions:
Hide

Test using Boost theme.

As an admin create a course with an Database activity.

Go to Database activity

Disable Javascript on your browser

Reload the page

Confirm the secondary navigation and course index are not visible.

Click on 'Import a preset' button

Confirm there is no error

Confirm you could see Presets list

Move your mouse over the "Actions" dropdown to show the options

Click on the import "Import preset" link

Confirm there is no error

Confirm you could see Presets list again
Show
Test using Boost theme. As an admin create a course with an Database activity. Go to Database activity Disable Javascript on your browser Reload the page Confirm the secondary navigation and course index are not visible. Click on 'Import a preset' button Confirm there is no error Confirm you could see Presets list Move your mouse over the "Actions" dropdown to show the options Click on the import "Import preset" link Confirm there is no error Confirm you could see Presets list again

Sprint:
HQ 2-week review sprint

Description

Since ~~MDL-75188~~ was integrated 'import' is no anymore allowed on preset.php page as action parameter. But we are still sending 'import' as action parameter to preset.php page on Import links on Presets tab, and 'Import a preset' button on empty database for Database and Templates pages. We should continue allowing this parameter value or changing the value is sent.

All those Import options should be catch by the JS to show the modal and it would work fine, but some times behat are quick enough to no let the JS catch the event and raised and error:

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

1_MDL-76179.png
62 kB
14/Nov/22 5:08 PM
2_MDL-76179.png
69 kB
14/Nov/22 5:08 PM
3_MDL-76179.mp4
364 kB
14/Nov/22 5:08 PM
image-2022-11-02-18-45-45-744.png
34 kB
03/Nov/22 1:45 AM

Issue Links

is a regression caused by

MDL-75188 Move "Import" preset form to a modal

Closed

Activity

People

Assignee:: Amaia Anabitarte

Reporter:: Amaia Anabitarte

Peer reviewer:: Carlos Escobedo

Integrator:: Ferran Recio

Tester:: John Edward Pedregosa

Participants:: Amaia Anabitarte, Carlos Escobedo, CiBoT, Ferran Recio, John Edward Pedregosa, Jun Pataleta

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 03/Nov/22 1:45 AM

Updated:: 16/Nov/22 12:14 AM

Resolved:: 16/Nov/22 12:14 AM

Fix Release Date:: 28/Nov/22

Time Tracking

Estimated:

Remaining:

Logged:

3h 45m