Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76179

Don't send 'import' value as action parameter to preset.php file if is not allowed

    XMLWordPrintable

Details

    • MOODLE_401_STABLE
    • MOODLE_401_STABLE
    • MDL-76179-master
    • Hide

      Test using Boost theme.

      1. As an admin create a course with an Database activity.
      2. Go to Database activity
      3. Disable Javascript on your browser
      4. Reload the page
      5. Confirm the secondary navigation and course index are not visible.
      6. Click on 'Import a preset' button
      7. Confirm there is no error
      8. Confirm you could see Presets list
      9. Move your mouse over the "Actions" dropdown to show the options
      10. Click on the import "Import preset" link
      11. Confirm there is no error
      12. Confirm you could see Presets list again
      Show
      Test using Boost theme. As an admin create a course with an Database activity. Go to Database activity Disable Javascript on your browser Reload the page Confirm the secondary navigation and course index are not visible. Click on 'Import a preset' button Confirm there is no error Confirm you could see Presets list Move your mouse over the "Actions" dropdown to show the options Click on the import "Import preset" link Confirm there is no error Confirm you could see Presets list again
    • HQ 2-week review sprint

    Description

      Since MDL-75188 was integrated 'import' is no anymore allowed on preset.php page as action parameter. But we are still sending 'import' as action parameter to preset.php page on Import links on Presets tab, and 'Import a preset' button on empty database for Database and Templates pages. We should continue allowing this parameter value or changing the value is sent.

      All those Import options should be catch by the JS to show the modal and it would work fine, but some times behat are quick enough to no let the JS catch the event and raised and error:

      Attachments

        1. image-2022-11-02-18-45-45-744.png
          image-2022-11-02-18-45-45-744.png
          34 kB
        2. 3_MDL-76179.mp4
          364 kB
        3. 2_MDL-76179.png
          2_MDL-76179.png
          69 kB
        4. 1_MDL-76179.png
          1_MDL-76179.png
          62 kB

        Issue Links

          Activity

            People

              amaia Amaia Anabitarte
              amaia Amaia Anabitarte
              Carlos Escobedo Carlos Escobedo
              Ferran Recio Ferran Recio
              John Edward Pedregosa John Edward Pedregosa
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 45 minutes
                  3h 45m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.