[MDL-76222] tool_customlang CLI export unneeded language string - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.11.10, 4.0.4
Fix Version/s: 4.2
Component/s: Language
Labels:

Affected Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_402_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull Master Branch:
~~MDL-76222~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-76222
Testing Instructions:
Hide

Log in as admin

Navigate to Language > Language customisation in site administration

Choose English (en)

Press Open language pack for editing

Under Show strings of these components select access.php and press Show strings

Set Local customisation for the core_access/accesshelp string

Press Save changes to the language pack

From CLI run the following command:

$ php admin/tool/customlang/cli/export.php --lang=en

Confirm you see the following message (note: <TEMPDIR> is whatever value you have for CFG->tempdir):

Starting to export lang files.

== Exporting language en ==

Zip created: <TEMPDIR>/customlang/customlang_en.zip
Show
Log in as admin Navigate to Language > Language customisation in site administration Choose English (en) Press Open language pack for editing Under Show strings of these components select access.php and press Show strings Set Local customisation for the core_access/accesshelp string Press Save changes to the language pack From CLI run the following command: $ php admin/tool/customlang/cli/export.php --lang=en Confirm you see the following message (note: <TEMPDIR> is whatever value you have for CFG->tempdir ): Starting to export lang files. == Exporting language en == Zip created: <TEMPDIR>/customlang/customlang_en.zip

Story Points:
1
Sprint:
Team Hedgehog Sprint 2.1

Description

From ~~MDL-75970~~, when using the tool_customlang CLI export the zip file is named using a language string exportzipfilename.

$string['exportzipfilename'] = 'customlang-export-{$a->lang}.zip'

I don't know of any reason for making the name of the zip file translatable. The zip file can easily be renamed, and giving it a hard-coded generic name makes it consistent with other exported content such as download course content, assignment submissions etc.

Thus, how about removing the language string exportzipfilename and naming the zip file something like

customlang-{$a->lang}.zip

(no need to include the word 'export').

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

(I) Passed -- (Master)MDL-76222.png
40 kB
16/Feb/23 1:10 PM

Issue Links

has a non-specific relationship to

MDL-75970 tool_customlang CLI export does not use a valid filename

Closed

Activity

People

Assignee:: Paul Holden

Reporter:: Helen Foster

Peer reviewer:: Huong Nguyen

Integrator:: Andrew Lyons

Tester:: Kim Jared Lucas

Participants:: Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Helen Foster, Huong Nguyen, Kim Jared Lucas, Paul Holden

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 07/Nov/22 10:22 PM

Updated:: 17/Feb/23 10:08 AM

Resolved:: 17/Feb/23 10:08 AM

Fix Release Date:: 24/Apr/23

Time Tracking

Estimated:

Remaining:

Logged:

1h 10m