-
Bug
-
Resolution: Fixed
-
Minor
-
4.1
-
MOODLE_401_STABLE
-
MOODLE_401_STABLE
-
MDL-76276-master -
Initial setup
- Enable and use the new TinyMCE editor.
- Navigate to /admin/settings.php?section=filtersettingdisplayh5p.
- Add https://moodle.h5p.com/content/[id]" to the "Allowed sources".
- Click Save changes.
- Create a course.
- Create a forum.
- View the forum.
Internal URL
- Ensure you are using localhost as the domain for your site, e.g $CFG->wwwroot = 'http://localhost/...';
- Navigate to the Content bank of the course.
- Upload the ipsums.h5p
. - View the forum.
- Click Add discussion topic button.
- Click Configure H5P content button.
- Click Browse repositories.
- Choose the file in the Content bank.
- Click the Insert H5P content button.
- Verify that you can insert the content normally.
- Verify that you will not see an Invalid URL error.
- Click Post to forum.
- View the Post.
- Verify that you can see the content of H5P.
External URL
- View the forum.
- Click Add discussion topic button.
- Click Configure H5P content button.
- Set the H5P Url to: https://moodle.h5p.com/content/1290729733828858779
- Click the Insert H5P content button.
- Verify that you can insert the content normally.
- Verify that you will not see an Invalid URL error.
- Click Post to forum.
- View the Post.
- Verify that you can see the content of H5P.
Initial setup Enable and use the new TinyMCE editor. Navigate to /admin/settings.php?section=filtersettingdisplayh5p. Add https://moodle.h5p.com/content/[id] " to the "Allowed sources". Click Save changes. Create a course. Create a forum. View the forum. Internal URL Ensure you are using localhost as the domain for your site, e.g $CFG->wwwroot = 'http://localhost/...'; Navigate to the Content bank of the course. Upload the ipsums.h5p . View the forum. Click Add discussion topic button. Click Configure H5P content button. Click Browse repositories. Choose the file in the Content bank. Click the Insert H5P content button. Verify that you can insert the content normally. Verify that you will not see an Invalid URL error. Click Post to forum. View the Post. Verify that you can see the content of H5P. External URL View the forum. Click Add discussion topic button. Click Configure H5P content button. Set the H5P Url to: https://moodle.h5p.com/content/1290729733828858779 Click the Insert H5P content button. Verify that you can insert the content normally. Verify that you will not see an Invalid URL error. Click Post to forum. View the Post. Verify that you can see the content of H5P.
-
2
-
Team Hedgehog Sprint 1.1
The root cause of this issue is the code is treating the Internal URL (Content bank) like the External URL and applying the validation.
We just need to skip the validation for Internal URL, as we did in Atto editor
The issue only happens if the site domain is config as same as wwwroot
— Original —
When trying to add H5P content using the H5P button in the new TinyMCE editor, the Invalid URL error is displayed when uploading a file or using any file in the Content bank repository:
This is probably a regression of MDL-76012.
