Loading...

XML

Word

Printable

Affected Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE
Fixed Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE
Pull from Repository:
https://github.com/mkassaei/moodle.git
Pull 4.1 Branch:
~~MDL-76293~~_401
Pull 4.1 Diff URL:
https://github.com/mkassaei/moodle/compare/MOODLE_401_STABLE...MDL-76293_401
Pull Main Branch:
~~MDL-76293~~
Pull Main Diff URL:
https://github.com/mkassaei/moodle/compare/master...MDL-76293
Testing Instructions:
Hide

Install a gradebook plugin (you can find some at https://moodle.org/plugins/?q=type:gradereport)

Before this patch applied

Ideally, before applying this path, verify you can reproduce the failure.

Run the phpunit test for general_action_bar_test class (vendor/bin/phpunit --testsuite core_grades_testsuite --filter general_action_bar_test)

Verify the test fails.

After this patch

Verify that the tests now pass.
Show
Install a gradebook plugin (you can find some at https://moodle.org/plugins/?q=type:gradereport ) Before this patch applied Ideally, before applying this path, verify you can reproduce the failure. Run the phpunit test for general_action_bar_test class ( vendor/bin/phpunit --testsuite core_grades_testsuite --filter general_action_bar_test ) Verify the test fails. After this patch Verify that the tests now pass.

The PHPUnit general_action_bar_test fails when added plugins are present and not in the expected list.

is a regression caused by

MDL-72873 Add tertiary navigation to the gradebook

is duplicated by

MDL-76201 The unit test `test_export_for_template_admin` has a data provider with hard coded 'gradereport' plugin values

Testing discovered

MDL-76657 Gradebook: Unit tests have hardcoded plugin names (grade/tests/output/general_action_bar_test.php)

Participants:: Andrew Lyons, CiBoT, Mahmoud Kassaei, Ron Carl Alfon Yu, Tim Hunt

Estimated:

Remaining:

Logged:

2h 26m

Before this patch applied