Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76304

Add ability to set pagesize via reports_get webservice

    XMLWordPrintable

Details

    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • MOODLE_402_STABLE
    • MDL-76304-master-add_pagesize_to_webservice
    • Hide

      Setup:

      1. Create a new test course size 'S' to populate the site with users
      2. Create a custom report named 'Users' using the 'Users' report source, include the default setup

      Verify existing functionality works:

      1. Visit the reportbuilder editor for the 'Users' report
      2. Click the 'Preview' button, verify the number of rows shown is 30

      Verify new pagesize parameter works:

      1. In reportbuilder/amd/src/editor.js line 74 set the pagesize parameter to 5.

        .then(() => getReport(reportElement.dataset.reportId, toggledEditMode, 5))

      2. Rebuild the JS using the `grunt amd` command while in the reportbuilder/amd/ folder
      3. Visit the reportbuilder editor for the 'Users' report
      4. Click the 'Preview' button, verify the number of rows shown is 5
      Show
      Setup: Create a new test course size 'S' to populate the site with users Create a custom report named 'Users' using the 'Users' report source, include the default setup Verify existing functionality works: Visit the reportbuilder editor for the 'Users' report Click the 'Preview' button, verify the number of rows shown is 30 Verify new pagesize parameter works: In reportbuilder/amd/src/editor.js line 74 set the pagesize parameter to 5. .then(() => getReport(reportElement.dataset.reportId, toggledEditMode, 5 )) Rebuild the JS using the `grunt amd` command while in the reportbuilder/amd/ folder Visit the reportbuilder editor for the 'Users' report Click the 'Preview' button, verify the number of rows shown is 5

    Description

      MDL-73184 added the ability to set a pagesize on a report, this isn't usable if you are rendering a report with JS by requesting the contents using the webservice `core_reportbuilder_reports_get`.

      The webservice should have an optional pagesize parameter to resolve this

      Attachments

        Activity

          People

            alexmorris Alexander Morris
            alexmorris Alexander Morris
            Paul Holden Paul Holden
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Carlos Castillo, David Matamoros, Mikel Martín Corrales, Paul Holden
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              24/Apr/23

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 6 hours, 8 minutes
                6h 8m