Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76309

Submissions download as ZIP not compatible with upload of feedback files

XMLWordPrintable

    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • MOODLE_401_STABLE
    • MDL-76309-MOODLE_401_STABLE
    • MDL-76309-master
    • Hide

      Prerequisites

      1. Create a course
      2. Enrol three students A, B, C
      3. Add a group G containing the students A and B

      Testing with individual submissions

      1. Create an assignment with feedback types "Offline grading worksheet" and "Feedback files" enabled and group submission disabled
      2. Create a submission for the students B and C
      3. Visit the assignment as a teacher
      4. Click on "View all submissions"
      5. Click on "Download all submissions" (top right of the page) with "Download submissions in folders" (bottom of the page) enabled
      6. Unzip the file.
      7. Add a file in the folder belonging to student C
      8. Re-ZIP the contents and upload the modified ZIP file choosing "Upload multiple feedback files in a zip" in the "Grading action" dropdown
      9. Confirm that you see the added file for student C
      10. Visit the assignment as a teacher
      11. Click on "View all submissions"
      12. Select student B in the table using the checkbox
      13. Choose on "Download selected submissions" in the "With selected..." dropdown with "Download submissions in folders" enabled (bottom of the page).
      14. Unzip the file.
      15. Add a file in the folder belonging to student B
      16. Re-ZIP the contents and upload the modified ZIP file choosing "Upload multiple feedback files in a zip" in the "Grading action" dropdown
      17. Confirm that you see the added file for student B

      Testing uploading folders

      1. Create an assignment with feedback types "Offline grading worksheet" and "Feedback files" enabled and group submission disabled
      2. Create a submission for the student A
      3. Visit the assignment as a teacher
      4. Click on "View all submissions"
      5. Click on "Download all submissions" (top right of the page) with "Download submissions in folders" (bottom of the page) enabled
      6. Unzip the file.
      7. Add a sub-folder "Test" in the folder belonging to student A
      8. Add a file to the sub-folder "Test"
      9. Re-ZIP the contents and upload the modified ZIP file choosing "Upload multiple feedback files in a zip" in the "Grading action" dropdown
      10. Confirm that you see the added file
      Show
      Prerequisites Create a course Enrol three students A, B, C Add a group G containing the students A and B Testing with individual submissions Create an assignment with feedback types "Offline grading worksheet" and "Feedback files" enabled and group submission disabled Create a submission for the students B and C Visit the assignment as a teacher Click on "View all submissions" Click on "Download all submissions" (top right of the page) with "Download submissions in folders" (bottom of the page) enabled Unzip the file. Add a file in the folder belonging to student C Re-ZIP the contents and upload the modified ZIP file choosing "Upload multiple feedback files in a zip" in the "Grading action" dropdown Confirm that you see the added file for student C Visit the assignment as a teacher Click on "View all submissions" Select student B in the table using the checkbox Choose on "Download selected submissions" in the "With selected..." dropdown with "Download submissions in folders" enabled (bottom of the page). Unzip the file. Add a file in the folder belonging to student B Re-ZIP the contents and upload the modified ZIP file choosing "Upload multiple feedback files in a zip" in the "Grading action" dropdown Confirm that you see the added file for student B Testing uploading folders Create an assignment with feedback types "Offline grading worksheet" and "Feedback files" enabled and group submission disabled Create a submission for the student A Visit the assignment as a teacher Click on "View all submissions" Click on "Download all submissions" (top right of the page) with "Download submissions in folders" (bottom of the page) enabled Unzip the file. Add a sub-folder "Test" in the folder belonging to student A Add a file to the sub-folder "Test" Re-ZIP the contents and upload the modified ZIP file choosing "Upload multiple feedback files in a zip" in the "Grading action" dropdown Confirm that you see the added file
    • HQ Sprint 1.3 Moppies

      When you download all submissions from an assignment as a ZIP file, in current 4.0 and earlier it was possible to keep the directory structure of the ZIP file, put feedback files in it and use it for bulk upload of feedback files.

      In 4.1 the directories miss the trailing underscore in the directory names. But they seem to be expected by the upload processor. So you can't upload feedback files in that easy way (manually renaming the directories helps, but users won't be very happy about that).

       

      Steps to reproduce:

      1. Create a course
      2. Enrol a student
      3. Create an assignment with feedback types "Offline grading worksheet" and "Feedback files" enabled.
         
      4. Create a submission for the student
      5. Visit the assignment as a teacher and download all submissions as a ZIP file with "Download submissions in folders" enabled.
      6. Add a file in the folder belonging to the student.
      7. Upload the modified ZIP file with "Upload multiple feedback files in a zip"
      8. You will see "No changes"

      Expected behavior here is to see the added file.

       

      The patch modifies the importer to accept paths without the trailing underscore. An alternative solution could be to add the trailing underscore in export (this also would improve backwards compatibility with moodle < 4.1).

            stefan.hanauska Stefan Hanauska
            stefan.hanauska Stefan Hanauska
            Mathew May Mathew May
            Jake Dallimore Jake Dallimore
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            15 Vote for this issue
            Watchers:
            19 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 5 hours, 40 minutes
                5h 40m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.