Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76319

Add missing continue button after csv grades import error

XMLWordPrintable

    • MOODLE_400_STABLE, MOODLE_402_STABLE
    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • 76319-gradebook-add-missing-continue-button-401
    • 76319-gradebook-add-missing-continue-button-master
    • Hide

      Setup:

      1. create a course
      2. go to grades tab
      3. select import in the dropdown menu grader report

      Test the first step form with an invalid csv file :

      1. import the following csv file or use the following file invalid-import-step-1.csv :

        column1
        foo,bar
        

      2. keep default values and submit the form with "upload grades" button
      3. Confirm you see this error message " Invalid CSV file format - number of columns is not constant! "
      4. press "continue" button
      5. Confirm you are redirected to "import csv" page

      Test the second step form with invalid data:

      1. import the following csv file or use the following file invalid-import-step-2.csv :

        userid,grade
        10000025,75
        

        1. Note: This must be an integer of a user that does not exist to avoid cross DB errors from interrupting the test
      2. keep default values and submit the form with "upload grades" button
      3. you should see another form named "import preview"
      4. keep default values and submit the form with "upload grades" button
      5. Confirm see 2 error messages : "User mapping error: Could not find user with id of "10000025"." and "Import failed. No data was imported."
      6. press "continue" button
      7. Confirm you are redirected to "import csv" page
      Show
      Setup: create a course go to grades tab select import in the dropdown menu grader report Test the first step form with an invalid csv file : import the following csv file or use the following file invalid-import-step-1.csv : column1 foo,bar keep default values and submit the form with "upload grades" button Confirm you see this error message " Invalid CSV file format - number of columns is not constant! " press "continue" button Confirm you are redirected to "import csv" page Test the second step form with invalid data: import the following csv file or use the following file invalid-import-step-2.csv : userid,grade 10000025,75 Note: This must be an integer of a user that does not exist to avoid cross DB errors from interrupting the test keep default values and submit the form with "upload grades" button you should see another form named "import preview" keep default values and submit the form with "upload grades" button Confirm see 2 error messages : "User mapping error: Could not find user with id of "10000025"." and "Import failed. No data was imported." press "continue" button Confirm you are redirected to "import csv" page

      When trying to import xml grades with invalid data, the user gets an exception with a continue button.
      Currently, when trying to import csv grades with invalid data, the user an exception without a continue button.

        1. error-csv-import.png
          error-csv-import.png
          18 kB
        2. error-xml-import.png
          error-xml-import.png
          15 kB
        3. invalid-import-step-1.csv
          0.0 kB
        4. invalid-import-step-2.csv
          0.0 kB
        5. MDL-76319-test_one.png
          MDL-76319-test_one.png
          277 kB
        6. MDL-76319-test_two.png
          MDL-76319-test_two.png
          267 kB
        7. Screenshot 2023-07-10 at 12.38.10 pm.png
          Screenshot 2023-07-10 at 12.38.10 pm.png
          253 kB

            jboulen Julien Boulen
            jboulen Julien Boulen
            Kevin Percy Kevin Percy
            Mathew May Mathew May
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 25 minutes
                2h 25m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.