[MDL-76327] TinyMCE autosave reset is aborted on page transition - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 4.1
Fix Version/s: 4.1
Component/s: HTML Editor (TinyMCE)
Labels:

Affected Branches:
MOODLE_401_STABLE
Fixed Branches:
MOODLE_401_STABLE
Epic Link:
TinyMCE Followups
Pull from Repository:
https://github.com/andrewnicols/moodle.git
Pull Master Branch:
~~MDL-76327~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/422da2ed45...MDL-76327-master
Testing Instructions:
Hide

Edit lib/editor/tiny/plugins/autosave/classes/external/reset_autosave_session.php in your editor

Before the {{$manager = }} call on line 84, add a call:

sleep(5);

Login as admin

Navigate to a course

Turn editing on

Add a new activity or resource

Choose an activity (Forum)

Fill in a name and description

Press "Save and return to course"

Add another new activity of the same time

Confirm that the description was not filled from the autosave

Open the forum you created in the first step

Add a new discussion:

Set the title

Type into the content editor

Without clicking out of the content editor first, go straight from typing some content to clicking on the "Post to forum" button

Afer the page loads press the "Add discussion topic" button

Confirm that the content was not filled from the autosave
Show
Edit lib/editor/tiny/plugins/autosave/classes/external/reset_autosave_session.php in your editor Before the {{$manager = }} call on line 84, add a call: sleep(5); Login as admin Navigate to a course Turn editing on Add a new activity or resource Choose an activity (Forum) Fill in a name and description Press "Save and return to course" Add another new activity of the same time Confirm that the description was not filled from the autosave Open the forum you created in the first step Add a new discussion: Set the title Type into the content editor Without clicking out of the content editor first, go straight from typing some content to clicking on the "Post to forum" button Afer the page loads press the "Add discussion topic" button Confirm that the content was not filled from the autosave

Story Points:
10
Sprint:
Team Hedgehog Sprint 1.1, Team Hedgehog Sprint 1.2

Description

I'm not sure if this behaviour is specific to forums, but was most noticeable there while I've been looking at various follow-ups in the ~~MDL-75071~~ epic. Reporting here in case it's worth investigating further as to the scope of this problem, and any resolution

Easiest to describe via reproduction steps:

Create a forum
- Add a description
Create another forum
- Description of first forum is autopopulated
Add discussion topic, post to forum
Add another discussion topic
- Message of first topic is autopopulated

Testing in fresh install, using Ubuntu/Firefox

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-76327.mp4
4.35 MB
25/Nov/22 9:06 AM

Issue Links

has a non-specific relationship to

MDL-76487 Tiny editor is still reloading old content (and console errors on save)

Closed

MDL-76463 Add sendBeacon to core/ajax

Open

Activity

People

Assignee:: Andrew Lyons

Reporter:: Paul Holden

Peer reviewer:: Meirza

Integrator:: Ilya Tregubov

Tester:: Ron Carl Alfon Yu

Participants:: Andrew Lyons, CiBoT, Huong Nguyen, Ilya Tregubov, Meirza, Paul Holden, Ron Carl Alfon Yu

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 16/Nov/22 7:00 PM

Updated:: 26/Nov/22 1:36 AM

Resolved:: 25/Nov/22 9:31 PM

Fix Release Date:: 28/Nov/22

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

5h 6m