[MDL-76333] Bennu - patch for PHP 8.1 compatibility, add a test - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 4.1
Fix Version/s: 4.1
Component/s: Calendar
Labels:
- ci

Affected Branches:
MOODLE_401_STABLE
Fixed Branches:
MOODLE_401_STABLE
Epic Link:
Prepare Moodle for PHP 8.1
Pull from Repository:
https://github.com/marinaglancy/moodle.git
Pull Master Branch:
~~MDL-76333~~-master
Pull Master Diff URL:
https://github.com/marinaglancy/moodle/compare/e45f7f691a...MDL-76333-master
Testing Instructions:
Hide

Open calendar

Create a custom events in the current month

Click "Import or export calendars", then button "Export calendar"

Fill the form and export calendar

Make sure the dates of the events look like this: 20221116T154800Z
Show
Open calendar Create a custom events in the current month Click "Import or export calendars", then button "Export calendar" Fill the form and export calendar Make sure the dates of the events look like this: 20221116T154800Z

Description

Export calendar is not tested and Bennu library that we use there uses strftime that is deprecated in PHP 8.1

1. Patch bennu library, it looks like it's abandoned - http://bennu.sourceforge.net/
2. Add a test for calendar export

Attachments

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-76333_testing.mp4
1.67 MB
17/Nov/22 11:14 AM

Issue Links

has a non-specific relationship to

MDL-76507 Random failure in "Export calendar in ics format" scenario

Closed

Activity

People

Assignee:: Marina Glancy

Reporter:: Marina Glancy

Peer reviewer:: Eloy Lafuente (stronk7)

Integrator:: Andrew Lyons

Tester:: Angelia Dela Cruz

Participants:: Andrew Lyons, Angelia Dela Cruz, CiBoT, Eloy Lafuente (stronk7), Marina Glancy

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 16/Nov/22 11:09 PM

Updated:: 30/Nov/22 11:28 PM

Resolved:: 18/Nov/22 8:34 PM

Fix Release Date:: 28/Nov/22

Time Tracking

Estimated:

0m

Remaining:

0m

Logged:

2h 30m