Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76367

TinyMCE editor not supporting RTL language

    XMLWordPrintable

Details

    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • MOODLE_400_STABLE
    • MDL-76367-400
    • MDL-76367-master
    • Hide

      4.0 and master

      1. Login as admin
      2. Navigate to Site admin -> Languages -> Language packs
      3. Install an RTL language such as Hebrew
      4. Navigate to Site admin -> Plugins - Text editors -> Manage text editors
      5. Ensure that the Legacy TinyMCE editor is enabled (it's just called TinyMCE in 4.0 and earlier)
      6. Move it to the top of the list to make it the default editor
      7. Open the user menu
      8. Choose Profile
      9. Edit your profile
      10. Modify the URL to append &lang=he (for Hebrew)
      11. Find the editor in the page and click into it
        1. Confirm that the cursor and any text you type is on the right of the page

      master only

      1. Navigate to Site admin -> Plugins - Text editors -> Manage text editors
      2. Ensure that the new TinyMCE editor is enabled
      3. Move it to the top of the list to make it the default editor
      4. Open the user menu
      5. Choose Profile
      6. Edit your profile
      7. Modify the URL to append &lang=he (for Hebrew)
      8. Find the editor in the page and click into it
        1. Confirm that the cursor and any text you type is on the right of the page
      Show
      4.0 and master Login as admin Navigate to Site admin -> Languages -> Language packs Install an RTL language such as Hebrew Navigate to Site admin -> Plugins - Text editors -> Manage text editors Ensure that the Legacy TinyMCE editor is enabled (it's just called TinyMCE in 4.0 and earlier) Move it to the top of the list to make it the default editor Open the user menu Choose Profile Edit your profile Modify the URL to append &lang=he (for Hebrew) Find the editor in the page and click into it Confirm that the cursor and any text you type is on the right of the page master only Navigate to Site admin -> Plugins - Text editors -> Manage text editors Ensure that the new TinyMCE editor is enabled Move it to the top of the list to make it the default editor Open the user menu Choose Profile Edit your profile Modify the URL to append &lang=he (for Hebrew) Find the editor in the page and click into it Confirm that the cursor and any text you type is on the right of the page

    Description

      Discovered while testing MDLQA-17371, there are two issues here:

      1. The TinyMCE langpack has a magic _dir string only present in RTL languages that was missing (now added)
      2. The Editor stylesheet is not transformed for RTL langauge at all (dates to MDL-55244).

      Steps to reproduce

      1. Install a new RTL language package in Site admin > Language > Language packs
      2. Choose Hebrew and press "Install selected language pack(s)"
      3. Make sure the tinyMCE editor is enalbed in Site admin > Plugins > Text editors > Manage editors
      4. Click on the arrow to put it on top so it becomes the selected editor
      5. Click on user profile > language then select the Hebrew
      6. Click on edit profile in profile and go to the editor
      7. Verify that all the tool bars and menu bars have the same view as not using an RTL language

      Attachments

        Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-76468 Invalid URL for editor stylesheet when slashargs set

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          Discovered while testing

          Functional Test - A test of a single Moodle feature MDLQA-17371 CLONE - Smoke test on the new TinyMCE editor

          • Major - Major loss of function, incorrect output
          • Passed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-76440 The TinyMCE editor is missing the directionality buttons

          • Major - Major loss of function, incorrect output
          • Closed

          Functional Test - A test of a single Moodle feature MDLQA-16980 CLONE - RTL site smoke test

          • Trivial - Cosmetic problem like misspelt words or misaligned text
          • Passed
          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-76331 Shorten langstring identifiers

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              dobedobedoh Andrew Lyons
              stevani.andolo@moodle.com Stevani Andolo
              Huong Nguyen Huong Nguyen
              Jun Pataleta Jun Pataleta
              Ron Carl Alfon Yu Ron Carl Alfon Yu
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                16/Jan/23

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 5 minutes
                  5h 5m