Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76380

Unable to edit OAuth2 Service if requireconfirmation is disabled

    XMLWordPrintable

Details

    • MOODLE_311_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE
    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • MDL-76380-401
    • Hide
      1. Log in as admin
      2. Navigate to Server > Oauth2 services in site administration
      3. Create new Google service
        • Name: Google
        • Client ID: random1
        • Client secret: random2
        • Require email verification: Yes
      4. Press Save changes
      5. Press Edit for your new service
        • Name: Google2
        • Client ID: random111
        • Client secret: random222
        • Require email verification: No
        • I understand that disabling...: Yes
      6. Press Save changes
      7. Confirm no error regarding unexpected acceptrisk
      8. Confirm the Name of your service was updated
      9. Press Edit for your service
      10. Confirm previous changes were persisted (Client ID, Client secret, Require email verification)
      Show
      Log in as admin Navigate to Server > Oauth2 services in site administration Create new Google service Name: Google Client ID: random1 Client secret: random2 Require email verification: Yes Press Save changes Press Edit for your new service Name: Google2 Client ID: random111 Client secret: random222 Require email verification: No I understand that disabling...: Yes Press Save changes Confirm no error regarding unexpected acceptrisk Confirm the Name of your service was updated Press Edit for your service Confirm previous changes were persisted ( Client ID, Client secret, Require email verification )
    • 2

    Description

      The form can't be submitted unless the acceptrisk checkbox is checked, but if you check that box and submit you get the error Unexpected property 'acceptrisk' requested:


      To reproduce:

      1. Create a new OAuth2 Service
        1. Uncheck the requireconfirmation checkbox ("Require email verification")
        2. Check the acceptrisk checkbox ("I understand that disabling email verification can be a security issue.")
        3. Save.
      2. Edit the new Service
        1. Try and save without checking either acceptrisk or requireconfirmation
          1. Form will not submit
        2. Try and save with requireconfirmation unchecked and acceptrisk checked
          1. Page will return to services index with error in screenshot and no values will be saved.

      Attachments

        Issue Links

          Activity

            People

              pholden Paul Holden
              david.saylor@moodle.com David Saylor
              Meirza Meirza
              Andrew Lyons Andrew Lyons
              Simey Lameze Simey Lameze
              Votes:
              4 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 55 minutes
                  1h 55m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.