[MDL-76389] PHP8 warning in theme_config->editor_css_files() - Moodle Tracker

XML

Word

Printable

Details

Type: Sub-task
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.11.11, 4.0.5, 4.1
Fix Version/s: 4.0.6
Component/s: HTML and CSS
Labels:
- ci

Affected Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE
Fixed Branches:
MOODLE_400_STABLE
Pull from Repository:
https://github.com/stronk7/moodle.git
Pull 4.0 Branch:
~~MDL-76389~~_400
Pull 4.0 Diff URL:
https://github.com/stronk7/moodle/compare/MDL-76389_400~1...MDL-76389_400
Pull Master Branch:
~~MDL-76389~~
Pull Master Diff URL:
https://github.com/stronk7/moodle/compare/MDL-76389~1...MDL-76389
Testing Instructions:
Hide

Examine the webserver logs (webserver.gz, in the artifacts generated by every run) of any CI run (ToBiC included) with this code applied.

Verify that there isn't any "foreach() argument must be of type array|object" case in the logs.
Show
Examine the webserver logs (webserver.gz, in the artifacts generated by every run) of any CI run (ToBiC included) with this code applied. Verify that there isn't any "foreach() argument must be of type array|object" case in the logs.

Description

Problem F: PHP8 warning in theme_config->editor_css_files(). It happens 12 times.

160656:[Tue Nov 15 09:02:05.331079 2022] [php:notice] [pid 4853] [client 172.28.0.6:33522] Default exception handler: Exception - Warning: foreach() argument must be of type array|object, null given in [dirroot]/lib/outputlib.php on line 968 Debug:
Error code: generalexceptionmessage

line 157 of /lib/behat/lib.php: Exception thrown

line 968 of /lib/outputlib.php: call to behat_error_handler()

line 1331 of /lib/outputlib.php: call to theme_config->editor_css_files()

line 129 of /theme/styles.php: call to theme_config->get_css_content_editor()
, referer: http://webserver131d771ed741fc3b/behatrun3/course/modedit.php?add=data&type=&course=100000&section=1&return=0&sr=0

Attachments

Issue Links

is a regression caused by

MDL-75386 Editor stylesheets does not include stylesheets for subplugins

Closed

Activity

People

Assignee:: Eloy Lafuente (stronk7)

Reporter:: Eloy Lafuente (stronk7)

Peer reviewer:: Paul Holden

Integrator:: Jun Pataleta

Tester:: Jun Pataleta

Participants:: CiBoT, Eloy Lafuente (stronk7), Jun Pataleta, Paul Holden, ToBiC

Component watchers:: Amy Groshek, David Scotson, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 20/Nov/22 6:06 PM

Updated:: 22/Nov/22 9:31 PM

Resolved:: 22/Nov/22 9:31 PM

Fix Release Date:: 16/Jan/23

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 30m