[MDL-76390] Remove remaining uses of magic setters in tool_lp\external::data_for_competency_summary() - Moodle Tracker

XML

Word

Printable

Details

Type: Sub-task
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 4.0.5, 4.1
Fix Version/s: 4.0.6
Component/s: Competencies
Labels:
- ci

Affected Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE
Fixed Branches:
MOODLE_400_STABLE
Pull from Repository:
https://github.com/stronk7/moodle.git
Pull 4.0 Branch:
~~MDL-76390~~_400
Pull 4.0 Diff URL:
https://github.com/stronk7/moodle/compare/MDL-76390_400~1...MDL-76390_400
Pull Master Branch:
~~MDL-76390~~
Pull Master Diff URL:
https://github.com/stronk7/moodle/compare/MDL-76390~1...MDL-76390
Testing Instructions:
Hide

Examine the webserver logs (webserver.gz, in the artifacts generated by every run) of any CI run (ToBiC included) with this code applied.

Verify that there isn't any "Use of magic setters and getters is deprecated" case in the logs.
Show
Examine the webserver logs (webserver.gz, in the artifacts generated by every run) of any CI run (ToBiC included) with this code applied. Verify that there isn't any "Use of magic setters and getters is deprecated" case in the logs.

Description

Since Moodle 3.3, the use of magic setters/getters in competencies stuff is deprecated (see ~~MDL-57273~~).

It seems that we have some uses in core:

154782:[Tue Nov 15 08:57:36.330964 2022] [php:notice] [pid 4607] [client 172.28.0.4:35302] Debugging: Use of magic setters and getters is deprecated. Use get() and set(). in

line 57 of /competency/classes/persistent.php: call to debugging()

line 281 of /admin/tool/lp/classes/external.php: call to core_competency
persistent->__call()

line 261 of /lib/externallib.php: call to tool_lp
external::data_for_competency_summary()

line 81 of /lib/ajax/service.php: call to external_api::call_external_function()
, referer: http://webserver131d771ed741fc3b/behatrun1/admin/tool/lp/user_competency_in_course.php?courseid=100000&competencyid=235001&userid=104000

Attachments

Activity

People

Assignee:: Eloy Lafuente (stronk7)

Reporter:: Eloy Lafuente (stronk7)

Peer reviewer:: Paul Holden

Integrator:: Jun Pataleta

Tester:: Jun Pataleta

Participants:: CiBoT, Eloy Lafuente (stronk7), Jun Pataleta, Paul Holden, ToBiC

Component watchers:: Jean-Philippe Gaudreau, Steve Massicotte, Serge Gauthier, Issam Taboubi, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 20/Nov/22 6:18 PM

Updated:: 22/Nov/22 9:31 PM

Resolved:: 22/Nov/22 9:31 PM

Fix Release Date:: 16/Jan/23

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 45m