Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76064 Fix problems reported in apache logs before 4.1 release
  3. MDL-76390

Remove remaining uses of magic setters in tool_lp\external::data_for_competency_summary()

    XMLWordPrintable

Details

    • Sub-task
    • Resolution: Fixed
    • Major
    • 4.0.6
    • 4.0.5, 4.1
    • Competencies
    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • MOODLE_400_STABLE
    • Hide
      1. Examine the webserver logs (webserver.gz, in the artifacts generated by every run) of any CI run (ToBiC included) with this code applied.
      2. Verify that there isn't any "Use of magic setters and getters is deprecated" case in the logs.
      Show
      Examine the webserver logs (webserver.gz, in the artifacts generated by every run) of any CI run (ToBiC included) with this code applied. Verify that there isn't any "Use of magic setters and getters is deprecated" case in the logs.

    Description

      Since Moodle 3.3, the use of magic setters/getters in competencies stuff is deprecated (see MDL-57273).

      It seems that we have some uses in core:

      154782:[Tue Nov 15 08:57:36.330964 2022] [php:notice] [pid 4607] [client 172.28.0.4:35302] Debugging: Use of magic setters and getters is deprecated. Use get() and set(). in

      Attachments

        Activity

          People

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Paul Holden Paul Holden
            Jun Pataleta Jun Pataleta
            Jun Pataleta Jun Pataleta
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 45 minutes
                2h 45m

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.