Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76426

Prepare Moodle for PHP 8.3

    XMLWordPrintable

Details

    • MOODLE_402_STABLE
    • MOODLE_404_STABLE
    • Prepare Moodle for PHP 8.3
    • Hide

      A) Verify the docs have been updated with the information about PHP 8.3 support., at very least:

      B) MDL-81479 - Verify that 404_STABLE (if already exists) and main can be installed using PHP 8.3

      C) MDL-81479 - Verify that a 401_STABLE site can be upgraded to 404_STABLE (if already exists and main using PHP 8.3)

      D) Check that all CI jobs are passing ok with PHP 8.3.

      Show
      A) Verify the docs have been updated with the information about PHP 8.3 support., at very least: PHP 8.3 support: https://moodledev.io/general/development/policies/php Existing release notes in all the branches affected, see: (to be created) for 4.4: https://moodledev.io/general/releases/4.4#server-requirements ( example issue ) B) MDL-81479 - Verify that 404_STABLE (if already exists) and main can be installed using PHP 8.3 C) MDL-81479 - Verify that a 401_STABLE site can be upgraded to 404_STABLE (if already exists and main using PHP 8.3) D) Check that all CI jobs are passing ok with PHP 8.3.

    Description


      (image taken after completion, now php83 is being tested everywhere, GHA, CIs... so no need for those custom tests and branches anymore)

      The, hopefully small, epic to turn Moodle ready for PHP 8.3.

      Target: Agreed to be Moodle 4.4 and up (as of January 15th 2024).

      When: Being cristal clear (aka transparent), the ideal target release for this is Moodle 4.4.0 (aka, supported since the very beginning of the branch), but be warned that full support may arrive later in any Moodle 4.4.x minor release in the branch, depending of a number of factors (extensions availability and bugs, 3rd part libraries, last minute surprises...).

      Some initial links:

      Some basic requirements for this:

      • Get unit and acceptance tests passing against all databases (may imply the need of upgrading phpunit/behat...).
      • Check that all the change details have been reviewed and fixed (attached file). Note that, until release, this file is considered WIP and subject to changes! Reference: https://github.com/php/php-src/blob/PHP-8.3/UPGRADING (MDL-81325)
      • Ensure that older versions of Moodle don't work with PHP 8.3 (MDL-76441)
      • (link) - get moodle-php-apache docker images working with the new php version.
      • Verify that php-parallel-lint/php-parallel-lint and others pass for all php versions (MDL-76442)
      • (added the related ones) There are a few - search in the tracker for any issue created about "php 8.3" or "php83". Add them to this epic after analysing them.
      • Link any issue that remains open in the previous PHP Epic.
      • FINAL: Verify that the apache logs are clean of PHP 8.3 notices/warnings/errors (MDL-76444)
      • FINAL: Verify that all the issues found by the dev version of PHPCompatibility are fixed or false positives (MDL-81194).
      • FINAL: When CIs are passing consistently, put all the MySQL (W) jobs in the target branches (6 per branch) of the Epic to, manually, use the new PHP version (note that later, in the TODOs, we'll undo this manual configuration).
      • FINAL: Get gha working with the new php version (MDL-76443).
      • FINAL: phpcs.xml.dist : Ensure that the testVersion config setting matches the range of PHP supported versions in all the affected branches. Note that for master branch we leave the range open always ( MDL-78496).
      • FINAL: (part of the epic testing instructions). Verify that both install and upgrade from lowest possible site works ok, without any error/warning/notice. Both cli and web (MDL-81479).
      • FINAL: (part of the epic testing instructions). Update docs (and others, see testing instructions) once this is ready. If needed to, ask for the creation of the next major release page in devdocs (example issue / example PR).
      • ...

      And some tasks to do once this is upstream:

      TODO 1: Review the travis (only moodle-plugin-ci) and/or github actions configuration for various repositories. The new PHP version needs to be covered. Known to need review / fix repos include:

      Attachments

        Issue Links

          Activity

            People

              moodle.com Moodle HQ
              dobedobedoh Andrew Lyons
              Votes:
              8 Vote for this issue
              Watchers:
              18 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 hours, 58 minutes
                  6h 58m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.