Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75976 META: Calls passing nulls to built in functions not accepting nulls
  3. MDL-76482

mustache helper does not return anything (and should)

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.0.6, 4.1.1
    • 4.0.5, 4.1.1
    • General
    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • MDL-76482-401
    • MDL-76482-master
    • Hide

      Behat and PHPUnit will ensure that there are no regressions
      There are no good and easy confirmation tests, but accessing a site whilst using PHP 8.1 will cease to complain about use of a null instead of a string in the mustache_helper_collection::strip_disallowed_helpers() functino in a call to {{preg_replace_callback()}

      Show
      Behat and PHPUnit will ensure that there are no regressions There are no good and easy confirmation tests, but accessing a site whilst using PHP 8.1 will cease to complain about use of a null instead of a string in the mustache_helper_collection::strip_disallowed_helpers() functino in a call to {{preg_replace_callback()}

      As discovered in MDL-76362, the mustache helper does not currently return a value in its helper function when one is expected to be returned. As a result, the following call to strip_disallowed_helpers (which calls preg_replace_callback()) is passing a null which will upset PHP 8.1 onwards.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Marina Glancy Marina Glancy
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 25 minutes
                1h 25m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.