Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-75976 META: Calls passing nulls to built in functions not accepting nulls
  3. MDL-76483

get_docs_url() does not properly handle its default value

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.0.6, 4.1.1
    • 4.0.5, 4.1.1
    • General
    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • MDL-76483-master
    • Hide

      PHPUnit and Behat will cover this for regressions.
      There is no easy way to positively test this, but if you use PHP 8.1 to access a site it will no longer complain about passing a null to subtr in get_docs_url().

      Show
      PHPUnit and Behat will cover this for regressions. There is no easy way to positively test this, but if you use PHP 8.1 to access a site it will no longer complain about passing a null to subtr in get_docs_url() .

      The get_docs_url() function has a signature:

       function get_docs_url($path = null) {

      However, it does not handle the case where $path is null - the first thing it does is to use it as a string in a substr check, which doesn't really do so well with a null value - and will warn/notice from 8.1.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Jun Pataleta Jun Pataleta
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 35 minutes
                35m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.