Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76612

Moodle 5.0 quiz final deprecations

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.1
    • Quiz
    • MOODLE_401_STABLE
    • MDL-76612_final-quiz-deprecations
    • Hide
      1. Run the following script:

        files=(
            "mod/quiz/accessmanager_form.php"
            "mod/quiz/accessmanager.php"
            "mod/quiz/accessrule/accessrulebase.php"
            "mod/quiz/attemptlib.php"
            "mod/quiz/cronlib.php"
            "mod/quiz/override_form.php"
            "mod/quiz/renderer.php"
            "mod/quiz/report/attemptsreport_form.php"
            "mod/quiz/report/attemptsreport_options.php"
            "mod/quiz/report/attemptsreport_table.php"
            "mod/quiz/report/attemptsreport.php"
            "mod/quiz/report/default.php"
        )
        for file in "${files[@]}"; do if [ -f "$file" ]; then echo "File exists: $file"; exit 1; fi done
        

      2. Verify the files are gone and the script outputs nothing
      3. Run the following commands:

        git grep -C2 -P '(?<!\w{1})no_questions_message\('
        git grep -C2 -P '(?<!\w{1})render_mod_quiz_links_to_other_attempts\('
        git grep -C2 -P '(?<!\w{1})render_quiz_nav_question_button\('
        git grep -C2 -P '(?<!\w{1})render_quiz_nav_section_heading\('
        git grep -C2 -P '(?<!\w{1})get_slot_tags_for_slot_id\('
        git grep -C2 -P '(?<!\w{1})is_display_number_customised\('
        git grep -C2 -P '(?<!\w{1})quiz_has_question_use\('
        git grep -C2 -P '(?<!\w{1})quiz_update_sumgrades\('
        git grep -C2 -P '(?<!\w{1})quiz_update_all_attempt_sumgrades\('
        git grep -C2 -P '(?<!\w{1})quiz_update_all_final_grades\('
        git grep -C2 -P '(?<!\w{1})quiz_set_grade\('
        git grep -C2 -P '(?<!\w{1})quiz_save_best_grade\('
        git grep -C2 -P '(?<!\w{1})quiz_calculate_best_grade\('
        git grep -C2 -P '(?<!\w{1})quiz_calculate_best_attempt\('git grep -C2 mod_quiz_overdue_attempt_updatergit grep -C2 moodle_quiz_exceptiongit grep -C2 TIME_TO_CACHE

      4. Verify it only returns the deprecated function stub and its mention in upgrade.txt or UPGRADING.MD
      5. Verify it returns nothing for the class names except its mention in upgrade.txt or UPGRADING.MD
      6. Verify it returns only false positives for the contstant and its mention in upgrade.txt or UPGRADING.MD
      Show
      Run the following script: files=( "mod/quiz/accessmanager_form.php" "mod/quiz/accessmanager.php" "mod/quiz/accessrule/accessrulebase.php" "mod/quiz/attemptlib.php" "mod/quiz/cronlib.php" "mod/quiz/override_form.php" "mod/quiz/renderer.php" "mod/quiz/report/attemptsreport_form.php" "mod/quiz/report/attemptsreport_options.php" "mod/quiz/report/attemptsreport_table.php" "mod/quiz/report/attemptsreport.php" "mod/quiz/report/default.php" ) for file in "${files[@]}"; do if [ -f "$file" ]; then echo "File exists: $file"; exit 1; fi done Verify the files are gone and the script outputs nothing Run the following commands: git grep -C2 -P '(?<!\w{1})no_questions_message\(' git grep -C2 -P '(?<!\w{1})render_mod_quiz_links_to_other_attempts\(' git grep -C2 -P '(?<!\w{1})render_quiz_nav_question_button\(' git grep -C2 -P '(?<!\w{1})render_quiz_nav_section_heading\(' git grep -C2 -P '(?<!\w{1})get_slot_tags_for_slot_id\(' git grep -C2 -P '(?<!\w{1})is_display_number_customised\(' git grep -C2 -P '(?<!\w{1})quiz_has_question_use\(' git grep -C2 -P '(?<!\w{1})quiz_update_sumgrades\(' git grep -C2 -P '(?<!\w{1})quiz_update_all_attempt_sumgrades\(' git grep -C2 -P '(?<!\w{1})quiz_update_all_final_grades\(' git grep -C2 -P '(?<!\w{1})quiz_set_grade\(' git grep -C2 -P '(?<!\w{1})quiz_save_best_grade\(' git grep -C2 -P '(?<!\w{1})quiz_calculate_best_grade\(' git grep -C2 -P '(?<!\w{1})quiz_calculate_best_attempt\('git grep -C2 mod_quiz_overdue_attempt_updatergit grep -C2 moodle_quiz_exceptiongit grep -C2 TIME_TO_CACHE Verify it only returns the deprecated function stub and its mention in upgrade.txt or UPGRADING.MD Verify it returns nothing for the class names except its mention in upgrade.txt or UPGRADING.MD Verify it returns only false positives for the contstant and its mention in upgrade.txt or UPGRADING.MD
    • Hide

      Code verified against automated checks.

      Checked MDL-76612 using repository: https://github.com/ziegenberg/moodle

      More information about this report

      Built on: Tue Apr 15 12:36:26 UTC 2025

      Show
      Code verified against automated checks. Checked MDL-76612 using repository: https://github.com/ziegenberg/moodle main (0 errors / 0 warnings) [branch: MDL-76612_final-quiz-deprecations | CI Job ] More information about this report Built on: Tue Apr 15 12:36:26 UTC 2025
    • Hide

      Launching automatic jobs for branch MDL-76612_final-quiz-deprecations

      Built on: Wed Apr 16 08:30:46 UTC 2025

      Show
      Launching automatic jobs for branch MDL-76612 _final-quiz-deprecations https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19043/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65119/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65120/ Behat (Firefox - boost) --> unrelated (can be ignored) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65121/ Behat (Firefox - classic) --> unrelated (can be ignored) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65122/ App tests (stable app version) --> unrelated (can be ignored) Built on: Wed Apr 16 08:30:46 UTC 2025

      This file lists the final deprecations from MDL-74923.

      Delete the following files:

      • mod/quiz/report/attemptsreport.php
      • mod/quiz/report/attemptsreport_form.php
      • mod/quiz/report/attemptsreport_options.php
      • mod/quiz/report/attemptsreport_table.php
      • mod/quiz/report/default.php
      • mod/quiz/accessmanager.php
      • mod/quiz/accessmanager_form.php
      • mod/quiz/cronlib.php
      • mod/quiz/override_form.php
      • mod/quiz/accessrule/accessrulebase.php
      • mod/quiz/renderer.php

      Clean up mod/quiz/db/renamedclasses.php

      Remove final deprecations from

      • mod/quiz/deprecatedlib.php
      • mod/quiz/report/statistics/classes/calculator.php
      • mod/quiz/classes/structure.php

            Daniel Ziegenberg Daniel Ziegenberg
            timhunt Tim Hunt
            Andrew Gosali Andrew Gosali
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 15 minutes
                3h 15m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.