Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76662

Logstore get_supported_reports test methods do not assert anything

    XMLWordPrintable

Details

    Description

      They currently have faulty logic in determining which supported reports are installed (possible as a result of this change from MDL-44596)

      The $allreports variable is keyed on plugin name without prefix (e.g. 'backups', 'competency') so the array key intersection will never return anything, leading to:

      $ bin/moodle-docker-compose exec webserver php vendor/bin/phpunit --filter test_get_supported_reports
      Moodle 4.2dev (Build: 20221209)
      Php: 7.4.33, mysqli: 5.7.40, OS: Linux 4.15.0-200-generic x86_64
      PHPUnit 9.5.26 by Sebastian Bergmann and contributors.
       
      ...                                                                 3 / 3 (100%)
       
      Time: 00:00.313, Memory: 300.00 MB
       
      OK (3 tests, 0 assertions)
      

      Attachments

        1. 311-402.png
          311-402.png
          476 kB
        2. 39.png
          39.png
          164 kB

        Issue Links

          Activity

            People

              pholden Paul Holden
              pholden Paul Holden
              Roberto Bravo Roberto Bravo
              Andrew Lyons Andrew Lyons
              Andrew Lyons Andrew Lyons
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 10 minutes
                  2h 10m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.