[MDL-76667] Form change checker is being triggered when submitting modal form via keypress - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 4.0.5, 4.1
Fix Version/s: 4.0.6, 4.1.1
Component/s: Forms Library, Report builder
Labels:
- ci
- triaged

Affected Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE
Fixed Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.0 Branch:
~~MDL-76667~~-400
Pull 4.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_400_STABLE...paulholden:MDL-76667-400
Pull 4.1 Branch:
~~MDL-76667~~-401
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...paulholden:MDL-76667-401
Pull Master Branch:
~~MDL-76667~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-76667
Testing Instructions:
Hide

Log in as admin

Navigate to Reports in user menu

Press New report

With your keyboard tab to the modal form Report source field to select a source

Tab back to the Name field and enter a name

While focus is still in the Name field hit Enter on your keyboard

Confirm the form is submitted successfully without dialogue box asking for confirmation that you want to leave the page, and you are viewing your new report
Show
Log in as admin Navigate to Reports in user menu Press New report With your keyboard tab to the modal form Report source field to select a source Tab back to the Name field and enter a name While focus is still in the Name field hit Enter on your keyboard Confirm the form is submitted successfully without dialogue box asking for confirmation that you want to leave the page, and you are viewing your new report

Description

See screencast:

It seems that when I submit the modal form by hitting Enter in the text field, the form change checker module is warning me of changes (in the form I'm trying to submit )

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

(I) Passed -- (400, 401, Master)MDL-76667.mp4
22/Dec/22 3:03 PM
2.75 MB
Kim Jared Lucas
Screencast 2022-12-13.gif
13/Dec/22 10:25 PM
192 kB
Paul Holden

Activity

People

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Huong Nguyen

Integrator:: Ilya Tregubov

Tester:: Kim Jared Lucas

Participants:: CiBoT, Huong Nguyen, Ilya Tregubov, Kim Jared Lucas, Paul Holden

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Carlos Castillo, David Matamoros, Mikel Martín Corrales, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 13/Dec/22 10:22 PM

Updated:: 22/Dec/22 8:52 PM

Resolved:: 22/Dec/22 8:52 PM

Fix Release Date:: 16/Jan/23

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 43m