Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76675

Better detection and handling of tzdata changes

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • 3.9.20, 3.11.13, 4.0.7, 4.1.2
    • 3.9.18, 3.11.11, 4.0.5, 4.1, 4.2
    • Unit tests

    Description

      This is a followup of MDL-76674 (the last case that has happened), and a myriad of similar issues, all them related to the inclusion or renaming of some TZ name.

      The problem is that those changes happen too often (say 5-10 times every year, each time that the IANA TZ database is updated).

      And, such a simple problem makes tests to fail everywhere! GHA, CI, local dev environments...

      So this issue is about:

      1. Make the current tests to stop looking, on every execution for ALL the timezones existence, just checking for a few, stable ones. So, normal runs out there won't become affected).
      2. Be able to, via opt-in configuration, force the check of ALL the timezones to happen.
      3. Ensure that the ALL timezones check is running somewhere, so we get informed ASAP.
      4. (Only if the previous point is not enough): Prospect some system, ideally automatic, able to warn us about changes ASAP (maybe a subscription to IANAs TZ announces...).

      I've put the 4th point as optional because, in the last case (MDL-76674)... we have started to detect the problems as of today (December 14th 2022) in GHA runs. And the last update (and availability) of the updated TZ data was November 29th 2022). See both the release and the availability of the PECL package:

      So, if we are able to detect the changes by continuously updating the timezonedb and running ALL tests, that will give us some good time to proceed with the updates before affecting to anybody (specially if "anybody" is unaffected, because of the point #1 of the plan - just run a subset normally).

      Ciao

      Attachments

        Issue Links

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              Paul Holden Paul Holden
              Andrew Lyons Andrew Lyons
              CiBoT CiBoT
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 1 hour, 10 minutes
                  1d 1h 10m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.