Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76690

Final deprecation of Report builder methods deprecated in 4.1

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.5
    • 4.1, 4.5
    • Report builder
    • MOODLE_401_STABLE, MOODLE_405_STABLE
    • MOODLE_405_STABLE
    • Hide
      1. Run the following:

        $ git grep -B1 -A2 "\(get_all_audiences_menu_types\|get_available_columns\)"
        

      2. Confirm the only matches are upgrade notes regarding deprecation, and deprecation annotation/calls
      Show
      Run the following: $ git grep -B1 -A2 "\(get_all_audiences_menu_types\|get_available_columns\)" Confirm the only matches are upgrade notes regarding deprecation, and deprecation annotation/calls

      In MDL-74600 the following Report builder methods were deprecated:

      • core_reportbuilder\local\helpers\audience::get_all_audiences_menu_types [*]
      • core_reportbuilder\local\helpers\report::get_available_columns

      As per step 2 of https://moodledev.io/general/development/policies/deprecation the method bodies should be replaced with exceptions

      [*] Note this method is also the sole caller of the private get_audience_types method, so this one should be removed too

            pholden Paul Holden
            pholden Paul Holden
            Carlos Castillo Carlos Castillo
            David Carrillo David Carrillo
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 11 minutes
                1h 11m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.