Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76693

Activity Chooser - Activity Summary content overlap/scroll issue

XMLWordPrintable

    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE
    • MDL-76693-401
    • MDL-76693-master
    • Hide

      Setup

      1. Log in as administrator
      2. Create a course
      3. Decrease the browser width between 576px and 992px (to show activity chooser information with scrolling)

      Test

      1. Go to the course page and switch edit mode on
      2. Click on Add an activity or resource
      3. Click on i (information icon) in the "Forum" activity
      4. Confirm that scroll is displayed for the modal content
      5. Scroll down and confirm all the content is displayed correctly
      Show
      Setup Log in as administrator Create a course Decrease the browser width between 576px and 992px (to show activity chooser information with scrolling) Test Go to the course page and switch edit mode on Click on Add an activity or resource Click on i (information icon) in the "Forum" activity Confirm that scroll is displayed for the modal content Scroll down and confirm all the content is displayed correctly
    • HQ 2023 Sprint i2.1 Moppies

      Using Quiz as an example:

      1. Go to a course
      2. Turn editing on
      3. Add an activity
      4. Find "Quiz"
      5. Select the "i" information icon to view the activity summary

       

      As in the screen recording attached "activity-chooser-screen-recording-issue", I have increased the font-size to 16px to be used as an example to demonstrate the issue. With a font-size increase, it is clear to see that the user cannot scroll to read all of the information clearly within the summary content; most notably the "More help" link at the bottom.

      The div that holds the "Back" and "Add" buttons covers this content. This leaves no flexibility for button sizes changing or padding increasing/decreasing.

       

      Proposed Solution

      • Add d-flex flex-column to .optionsummary container
      • Add flex-grow-1 to the .content container and remove the mb-5 class
      • Remove fixed-bottom position-absolute classes from the inner .modal-footer container which holds the "back" and "add" buttons.

      Please see screen recording attached "activity-chooser-screen-recording-proposed-solution" with this solution in action.

            mikelmartíncorrales Mikel Martín Corrales
            eimear.corrigan Eimear Corrigan
            Ferran Recio Ferran Recio
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 30 minutes
                3h 30m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.