[MDL-76731] Behat: add possibility to skip tests according to Moodle version - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9.18, 3.11.11, 4.0.5, 4.1, 4.2
Fix Version/s: 3.9.19, 3.11.12, 4.0.6, 4.1.1
Component/s: Automated functional tests (behat)
Labels:
- ci
- hqteam_hedgehog
- patch
- triaged

Affected Branches:
MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE
Fixed Branches:
MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE
Pull from Repository:
https://github.com/PhilippImhof/moodle.git
Pull 3.9 Branch:
~~MDL-76731~~_39
Pull 3.9 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_39_STABLE...PhilippImhof:moodle:MDL-76731_39
Pull 3.11 Branch:
~~MDL-76731~~_311
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...PhilippImhof:moodle:MDL-76731_311
Pull 4.0 Branch:
~~MDL-76731~~_400
Pull 4.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_400_STABLE...PhilippImhof:moodle:MDL-76731_400
Pull 4.1 Branch:
~~MDL-76731~~_401
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...PhilippImhof:moodle:MDL-76731_401
Pull Master Branch:
~~MDL-76731~~_master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...PhilippImhof:moodle:MDL-76731_master
Testing Instructions:
Hide

Open mod/quiz/tests/behat/add_quiz.feature

Add the line Given the site is running Moodle version 5.0 or higher as the first line of the Background section

Run the test and verify the output says: "1 test skipped" (or similar)

Change the newly added line to Given the site is running Moodle version 3.9 or higher

Run the test again and verify it passes.

Remove the newly added line and add Given the site is running Moodle version 3.0 or lower instead

Run the test again and verify the output says: "1 test skipped" (or similar)

Change the newly added line to Given the site is running Moodle version 4.2 or lower

Run the test again and verify it passes.

Remove the newly added line in order to revert the test to its original state.
Show
Open mod/quiz/tests/behat/add_quiz.feature Add the line Given the site is running Moodle version 5.0 or higher as the first line of the Background section Run the test and verify the output says: "1 test skipped" (or similar) Change the newly added line to Given the site is running Moodle version 3.9 or higher Run the test again and verify it passes. Remove the newly added line and add Given the site is running Moodle version 3.0 or lower instead Run the test again and verify the output says: "1 test skipped" (or similar) Change the newly added line to Given the site is running Moodle version 4.2 or lower Run the test again and verify it passes. Remove the newly added line in order to revert the test to its original state.

Description

In some cases, acceptance tests must be written in a different way for older and newer versions of Moodle. I suggest adding two new steps to make sure the behat site is running at least / at most a certain Moodle version. If this requirement is not met, the test will be skipped instead of failing.

The suggested patch is heavily based on a suggestion from dobedobedoh. Thanks!

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

(I) Passed -- (Master)MDL-76731.png
105 kB
28/Dec/22 6:14 PM

Activity

People

Assignee:: PhilippImhof

Reporter:: PhilippImhof

Peer reviewer:: Eloy Lafuente (stronk7)

Integrator:: Ilya Tregubov

Tester:: Kim Jared Lucas

Participants:: CiBoT, Eloy Lafuente (stronk7), Ilya Tregubov, Kim Jared Lucas, PhilippImhof, ToBiC

Component watchers:

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 20/Dec/22 6:27 PM

Updated:: 29/Dec/22 9:35 PM

Resolved:: 29/Dec/22 9:35 PM

Fix Release Date:: 16/Jan/23

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 9m