Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76811

Generator unit tests for mod_data generator wrong

XMLWordPrintable

      This is a regression caused by MDL-75234 but made worse by poor unit test writing.

      The test_create_field test is testing that the newly created field was added to the addtemplate template, but it is not.

      The template is empty, because the line that fills it was removed in MDL-75234.
      The test does not fail because strpos('', 'anything') === false and (false >= 0) === true.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Simey Lameze Simey Lameze
            Paul Holden Paul Holden
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 3 minutes
                2h 3m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.