[MDL-76812] Report audience exporter doesn't uniquely key the menu cards - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 4.1
Fix Version/s: 4.1.1
Component/s: Report builder
Labels:

Affected Branches:
MOODLE_401_STABLE
Fixed Branches:
MOODLE_401_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.1 Branch:
~~MDL-76812~~-401
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...paulholden:MDL-76812-401
Pull Master Branch:
~~MDL-76812~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-76812

Testing Instructions:

Hide

Make the following change:

diff --git a/reportbuilder/classes/external/custom_report_audience_cards_exporter.php b/reportbuilder/classes/external/custom_report_audience_cards_exporter.php

index 561e140..c13c8ed 100644

--- a/reportbuilder/classes/external/custom_report_audience_cards_exporter.php

+++ b/reportbuilder/classes/external/custom_report_audience_cards_exporter.php

@@ -57,7 +57,7 @@ class custom_report_audience_cards_exporter extends custom_report_menu_cards_exp

                 if ($plugininfo = core_plugin_manager::instance()->get_plugin_info($component)) {

                     $componentname = $plugininfo->displayname;

                 } else {

-                    $componentname = get_string('site');

+                    $componentname = random_string(5);//get_string('site');

                 // New menu card per component.

Navigate to Reports from user menu
Create a new report
Press Audience tab in editor
Confirm each of the menu cards (with random names) can be opened/closed independently of the others

Show

Make the following change: diff --git a/reportbuilder/classes/external/custom_report_audience_cards_exporter.php b/reportbuilder/classes/external/custom_report_audience_cards_exporter.php index 561e140..c13c8ed 100644 --- a/reportbuilder/classes/external/custom_report_audience_cards_exporter.php +++ b/reportbuilder/classes/external/custom_report_audience_cards_exporter.php @@ -57,7 +57,7 @@ class custom_report_audience_cards_exporter extends custom_report_menu_cards_exp if ($plugininfo = core_plugin_manager::instance()->get_plugin_info($component)) { $componentname = $plugininfo->displayname; } else { - $componentname = get_string('site'); + $componentname = random_string(5);//get_string('site'); } // New menu card per component. Navigate to Reports from user menu Create a new report Press Audience tab in editor Confirm each of the menu cards (with random names) can be opened/closed independently of the others

Description

The audience card index is reset to 0 inside the loop: https://github.com/moodle/moodle/blob/b8b905cd90f7a1d0db59a70a32d47e015dcfbfea/reportbuilder/classes/external/custom_report_audience_cards_exporter.php#L62-L67 (it should be initialized before the loop)

This means the menu cards do not collapse independently of one another, because they all have the same key, more noticeable in Workplace because we have audience types from multiple plugins but can be replicated in LMS by randomising the card names:

Regression from ~~MDL-74600~~ (and the same thing we previously fixed at ~~MDL-73811~~)

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

401.gif
11/Jan/23 9:00 AM
339 kB
Ron Carl Alfon Yu
master.gif
11/Jan/23 9:00 AM
400 kB
Ron Carl Alfon Yu
Screencast 2023-01-06.gif
06/Jan/23 6:04 PM
362 kB
Paul Holden

Issue Links

duplicates

MDL-73811 Report audience side bars don't collapse independently

Closed

is a regression caused by

MDL-74600 Improve custom report editor menu card exporters

Closed

Testing discovered

MDL-76815 Consistent use of method to determine component of report audience

Closed

Activity

People

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Ruslan Kabalin

Integrator:: Jun Pataleta

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Jun Pataleta, Paul Holden, Ron Carl Alfon Yu, Ruslan Kabalin

Component watchers:: Carlos Castillo, David Matamoros, Mikel Martín Corrales, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 06/Jan/23 5:53 PM

Updated:: 13/Jan/23 11:56 AM

Resolved:: 13/Jan/23 11:56 AM

Fix Release Date:: 16/Jan/23

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 4m