Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76974

Deprecate old method of setting user preferences via JS

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.3
    • 4.2
    • JavaScript
    • MOODLE_402_STABLE
    • MOODLE_403_STABLE
    • Hide

      Automated test

      1. Largely covered by existing Behat scenarios, e.g.:

      Manual test

      1. Ensure you have browser console open, watching network requests
      2. Log in as admin
      3. Navigate to Profile from user menu
      4. Press Edit profile
      5. Scroll down to New picture field
      6. Press Display folder as file tree in the filemanager element
      7. Confirm there is a request to the core_user_set_user_preferences service method (in your browser console network tab)
      8. Reload the page
      9. Confirm Display folder as file tree is still selected in the filemanager element
      10. Press Add in the New picture filemanager element
      11. Press Recent files in the File picker dialogue
      12. Confirm there is a request to the core_user_set_user_preferences service method
      13. Press Display folder as file tree in the File picker dialogue
      14. Confirm there is a request to the core_user_set_user_preferences service method
      15. Close the dialogue
      16. Reload the page
      17. Press Add in the New picture filemanager element
      18. Confirm Recent files is selected
      19. Confirm Display folder as file tree is selected
      20. Create a new course
      21. Navigate to Participants > Enrolment methods in course
      22. Press Enrol users in the Manual enrolments row
      23. Expand Search options
      24. Confirm there is a request to the core_user_set_user_preferences service method
      25. Tick Match the search text anywhere in the displayed fields
      26. Confirm there is a request to the core_user_set_user_preferences service method
      27. Reload the page
      28. Confirm Search options is expanded
      29. Confirm Match the search text anywhere in the displayed fields is ticked
      Show
      Automated test Largely covered by existing Behat scenarios, e.g.: https://github.com/moodle/moodle/blob/1b1a15a30879fc05650dd6aa4460ce7167f94a5b/mod/workshop/tests/behat/workshop_section_remembered.feature#L24 https://github.com/moodle/moodle/blob/1b1a15a30879fc05650dd6aa4460ce7167f94a5b/blocks/site_main_menu/tests/behat/edit_activities.feature#L68-L70 https://github.com/moodle/moodle/blob/1b1a15a30879fc05650dd6aa4460ce7167f94a5b/blocks/navigation/tests/behat/view_my_courses.feature#L79 Manual test Ensure you have browser console open, watching network requests Log in as admin Navigate to Profile from user menu Press Edit profile Scroll down to New picture field Press Display folder as file tree in the filemanager element Confirm there is a request to the core_user_set_user_preferences service method (in your browser console network tab) Reload the page Confirm Display folder as file tree is still selected in the filemanager element Press Add in the New picture filemanager element Press Recent files in the File picker dialogue Confirm there is a request to the core_user_set_user_preferences service method Press Display folder as file tree in the File picker dialogue Confirm there is a request to the core_user_set_user_preferences service method Close the dialogue Reload the page Press Add in the New picture filemanager element Confirm Recent files is selected Confirm Display folder as file tree is selected Create a new course Navigate to Participants > Enrolment methods in course Press Enrol users in the Manual enrolments row Expand Search options Confirm there is a request to the core_user_set_user_preferences service method Tick Match the search text anywhere in the displayed fields Confirm there is a request to the core_user_set_user_preferences service method Reload the page Confirm Search options is expanded Confirm Match the search text anywhere in the displayed fields is ticked

      We have a few places hanging around that use the following (to be replaced with WS calls from MDL-62859 plus standard component callbacks for permission checks):

            pholden Paul Holden
            pholden Paul Holden
            Andrew Lyons Andrew Lyons
            Jun Pataleta Jun Pataleta
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 39 minutes
                3h 39m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.