Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-76990

Recover move right/left functionality removed/hidden for 4.0

    XMLWordPrintable

Details

    • MOODLE_402_STABLE
    • MOODLE_402_STABLE
    • MDL-76990-master
    • Hide

      Mainly covered by behat and unit tests.

      Manual test to check the UI

      1. As admin create a course with 2 different activities.
      2. Go to the course and turn editing on.
      3. Open the action menu for the first activity. 
      4. Confirm there is a 'Move right' action.
      5. Confirm there is no 'Move left' action.
      6. Click on 'Move right' action.
      7. Confirm the first  activity card has no border anymore.
      8. Confirm the left margin of the first activity card is bigger than the rest of the activities.
      9. Open the action menu for the second activity.
      10. Click on 'Move right' action.
      11. Confirm the second activity card has top border only.
      12. Confirm the top border of the second activity is not rounded.
      13. Confirm the left margin of the second activity card is bigger than before moving activity to the right.
      14. Open the action menu for the first activity.
      15. Click on 'Move left' action.
      16. Confirm the first activity has a full border.
      17. Confirm the second activity has no border.
      18. Confirm the left margin of the first activity is the same as the beginning.
      Show
      Mainly covered by behat and unit tests. Manual test to check the UI As admin create a course with 2 different activities. Go to the course and turn editing on. Open the action menu for the first activity.  Confirm there is a 'Move right' action. Confirm there is no 'Move left' action. Click on 'Move right' action. Confirm the first  activity card has no border anymore. Confirm the left margin of the first activity card is bigger than the rest of the activities. Open the action menu for the second activity. Click on 'Move right' action. Confirm the second activity card has top border only. Confirm the top border of the second activity is not rounded. Confirm the left margin of the second activity card is bigger than before moving activity to the right. Open the action menu for the first activity. Click on 'Move left' action. Confirm the first activity has a full border. Confirm the second activity has no border. Confirm the left margin of the first activity is the same as the beginning.
    • 3
    • HQ 2023 Sprint i1.1 Moppies

    Description

      As a teacher
      I want to be able to indent activities
      so I could simulate a hierarchy on my course

       

      Move right/left functionality was removed from Moodle 4.0. We want to recover the functionality as in 3.11 but with some changes:

      • This issue doesn't include any migration/upgrading process. So the value for 'indent' field in the course_modules table of the database won't change by default.
      • There is only one indentation level allowed. So the teacher could move the activity once to the right. That means that when the teacher moves any activity to the right, the new value for 'indent' field in the 'course_modules' table will be 1.  And when the teacher moves any activity to the left, the new value for 'indent' field in the 'course_modules' table will be 0. Whatever the previous value of the 'indent' field was.
      • For activities with 'indent' value 0 or any negative value, there will be an option to 'Move right', but not to 'Move left'.* 
      • For activities with 'indent' value higher than 0, there will be an option to 'Move left', but not to 'Move right'.*
      • For activities with 'indent' value higher than 0, the activity card will have a bigger margin on the left part as shown in the prototype.*

      *: Remember for RTL languages the functionality should be the opposite, as in 3.11

       

      Note: A backporting request would be raised once this issue is integrated,  so we should try to implement the patch following the rules to be backportable. More information about backporting request: https://moodledev.io/general/development/policies/backporting

       

      Attachments

        Issue Links

          Activity

            People

              amaia Amaia Anabitarte
              amaia Amaia Anabitarte
              Carlos Escobedo Carlos Escobedo
              Jun Pataleta Jun Pataleta
              Kim Jared Lucas Kim Jared Lucas
              Votes:
              2 Vote for this issue
              Watchers:
              15 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 week, 2 hours, 10 minutes
                  1w 2h 10m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.