[MDL-77100] Remove uses of str_ends_with() from core - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_401_STABLE, MOODLE_402_STABLE
Fixed Branches:
MOODLE_401_STABLE
Epic Link:
Prepare Moodle for PHP 8.1
Pull from Repository:
https://github.com/paulholden/moodle
Pull 4.1 Branch:
~~MDL-77100~~-401
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...paulholden:MDL-77100-401
Pull Master Branch:
~~MDL-77100~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-77100
Testing Instructions:
Hide

Execute the following:

$ vendor/bin/phpunit mod/data/tests/preset_test.php --filter test_export

Confirm it passes with OK (1 test, 23 assertions)
Show
Execute the following: $ vendor/bin/phpunit mod/data/tests/preset_test.php --filter test_export Confirm it passes with OK (1 test, 23 assertions)

This was detected as part of ~~MDL-73587~~ (PHPCompatibility complete run against codebase).

The function str_ends_with() is not present in PHP version 7.4 or earlier

It's working because PHPUnit installs a php80 polyfill, making the function available, bur we shouldn't have it in core.

Discovered while testing

MDL-73587 Perform a complete PHPCompatibility 8.1 execution against codebase

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Estimated:

Not Specified

Remaining:

Logged:

26m