Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77104

Perform a complete PHPCompatibility 8.2 execution against codebase

    XMLWordPrintable

Details

    • MOODLE_402_STABLE
    • MOODLE_402_STABLE
    • Hide

      Review the results of the attached compatibility check results file in conjunction with the results from the previous check in MDL-73587 and decide if the actions and decisions are correct

      Show
      Review the results of the attached compatibility check results file in conjunction with the results from the previous check in MDL-73587 and decide if the actions and decisions are correct

    Description

      This task is one of the final ones to perform when everything else in the epic has been already applied.

      It's about to run the PHPCompatibility standard (that we usually also run as part of our local_codechecker) against the whole codebase.

      Prerequisites:

      1. The epic must be almost finished (to avoid detecting problems that correspond to other issues).
      2. PHPCompatibility must support the php versions being checked.
      3. Determine the range of PHP versions supported for the branch (8.0-8.2). See MDL-76724 for 4.3 reqs.

      To perform the run against master, just:

      1. Clone https://github.com/PHPCompatibility/PHPCompatibility locally.
      2. Ensure you're in the "develop" branch (the "master" branch contains the latest release, quite old now 2019).
      3. run composer install
      4. Run:

        export DIRROOT=/path/to/your/moodle ; vendor/bin/phpcs \
            --standard=PHPCompatibility \
            --runtime-set testVersion 8.0-8.2 \
            --extensions=php \
            --ignore=$DIRROOT/vendor/,$DIRROOT/local/ \
            --cache=/tmp/cache -p $DIRROOT
        

      5. Generate a RTF file with the report and start processing it.
      6. Look for detected stuff, discard false positives (it can be useful to look to the results of the previous PHP 8.1 Epic - MDL-73587) to drag any decision already taken there to this issue.

      Attachments

        Issue Links

          Activity

            People

              matt.porritt@moodle.com Matt Porritt
              stronk7 Eloy Lafuente (stronk7)
              Huong Nguyen Huong Nguyen
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 30 minutes
                  1d 30m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.