-
Task
-
Resolution: Fixed
-
Minor
-
4.2
-
MOODLE_402_STABLE
-
MOODLE_402_STABLE
-
This task is one of the final ones to perform when everything else in the epic has been already applied.
It's about to run the PHPCompatibility standard (that we usually also run as part of our local_codechecker) against the whole codebase.
Prerequisites:
- The epic must be almost finished (to avoid detecting problems that correspond to other issues).
- PHPCompatibility must support the php versions being checked.
- Determine the range of PHP versions supported for the branch (8.0-8.2). See
MDL-76724for 4.3 reqs.
To perform the run against master, just:
- Clone https://github.com/PHPCompatibility/PHPCompatibility locally.
- Ensure you're in the "develop" branch (the "master" branch contains the latest release, quite old now 2019).
- run composer install
- Run:
export DIRROOT=/path/to/your/moodle ; vendor/bin/phpcs \
--standard=PHPCompatibility \
--runtime-set testVersion 8.0-8.2 \
--extensions=php \
--ignore=$DIRROOT/vendor/,$DIRROOT/local/ \
--cache=/tmp/cache -p $DIRROOT
- Generate a RTF file with the report and start processing it.
- Look for detected stuff, discard false positives (it can be useful to look to the results of the previous PHP 8.1 Epic -
MDL-73587) to drag any decision already taken there to this issue.
- has a clone
-
MDL-81194 Perform a complete PHPCompatibility 8.3 execution against codebase
- Closed
- has a non-specific relationship to
-
MDL-76724 Decide Moodle 4.3 requirements and push them to environment.xml (due date: 2023-05-08)
- Closed
- is a clone of
-
MDL-73587 Perform a complete PHPCompatibility 8.1 execution against codebase
- Closed
- is parent of
-
MDL-78892 Question: explicity set $flags for html_entity_decode function
- Open