-
Bug
-
Resolution: Fixed
-
Major
-
4.1.1
While LTI icons are being shown in the Administrative view, they're turning completely white in the course view.
See attached images below for a sample of it not working in the class course view, but working in the administrative set up view.
This class - https://github.com/moodle/moodle/blob/master/theme/boost/scss/moodle/icons.scss#L150 - is adding a brightness of 0 and then inverting it, essentially making all images a white square or a white png. While this was presumably done for standard icons where the icons are known to be white and transparent, the icons can also be LTI tool icons that are added dynamically via external tools. When you do that, it makes the icons completely white, unlike the icon that shows up in the LTI administrative view.
One could argue that providers of LTI should offer up a transparent PNG, but LTI tool endpoints are almost never unique to an LMS. So that would mean a white/blank image in other LMS's that aren't Moodle. Moodle should respect the logo as designated by LTI.
You could add :not(.modicon_lti) like below to make this work correctly, or a new class to specify an LTI icon.
@each $type, $value in $activity-icon-colors { |
.activityiconcontainer.#{$type}:not(.modicon_lti) {
|
background-color: $value;
|
.activityicon,
|
.icon {
|
filter: brightness(0) invert(1); |
}
|
}
|
}
|
Thanks.
Â
- caused a regression
-
MDL-82740 CSS filter does not apply to monologo icons added in themes.
-
- Closed
-
- has a non-specific relationship to
-
MDL-77891 Non-monologo icons are not supported on Calendar day page and in event popovers
-
- Closed
-
-
MDL-76885 Activity icons redesign
-
- Closed
-
- has been marked as being related by
-
MDL-79947 Activity icons named icon.png or icon.svg are not allowed on theme pix_plugins folder
-
- Open
-
-
MDL-77898 Non-monologo icons are being displayed as whitened out in the upcoming events block
-
- Closed
-
-
MOBILE-4308 Remove filter for non-shape icons
-
- Closed
-
- is duplicated by
-
MDL-75611 MIME-Type icons incompatible with new boost design
-
- Closed
-