Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77128

Backport MDL-72324 to Moodle 3.9

    XMLWordPrintable

Details

    • MOODLE_39_STABLE
    • MOODLE_39_STABLE
    • Hide

      Prerequisites: Clone the same version tester used in MDL-59562

      git clone git@github.com:Peterburnett/mdl-59562-tester.git admin/tool/versiontester
      

      1) Start an upgrade from the web, and confirm on the 'Plugins check' step that you see the error 'Incompatible Moodle version: 39'

      2) Run a CLI upgrade:

      php admin/cli/upgrade.php

      3) Verify that you see a message about failed dependency check:

      Dependencies check failed for tool_versiontester
      You must solve all the plugin requirements before proceeding to install this Moodle version!

      4) Edit admin/tool/versiontester/version.php and change the incompatible declaration to `$plugin->incompatible = 410;`

      5) Run a CLI upgrade again:

       php admin/cli/upgrade.php

      6) Verify that the upgrade continues and prompts for confirmation.

      Show
      Prerequisites: Clone the same version tester used in MDL-59562 git clone git @github .com:Peterburnett/mdl- 59562 -tester.git admin/tool/versiontester 1) Start an upgrade from the web, and confirm on the 'Plugins check' step that you see the error 'Incompatible Moodle version: 39' 2) Run a CLI upgrade: php admin/cli/upgrade.php 3) Verify that you see a message about failed dependency check: Dependencies check failed for tool_versiontester You must solve all the plugin requirements before proceeding to install this Moodle version! 4) Edit admin/tool/versiontester/version.php and change the incompatible declaration to `$plugin->incompatible = 410;` 5) Run a CLI upgrade again: php admin/cli/upgrade.php 6) Verify that the upgrade continues and prompts for confirmation.

    Description

      MDL-72324 was never applied to Moodle 3.9 and Moodle 3.10, which means that a plugin developer who's still supporting the LTS releases can't include a supported range starting at 39 and set the incompatible value, because unit tests on the MOODLE_39_STABLE will always fail (see for example https://github.com/LafColITS/moodle-local_remote_courses/actions/runs/4077464517).

      Attachments

        Issue Links

          Activity

            People

              cfulton Charles Fulton
              cfulton Charles Fulton
              Paul Holden Paul Holden
              Andrew Lyons Andrew Lyons
              Ron Carl Alfon Yu Ron Carl Alfon Yu
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                24/Apr/23

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 12 minutes
                  1h 12m