[MDL-77128] Backport MDL-72324 to Moodle 3.9 - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9.20
Fix Version/s: 3.9.21
Component/s: Administration
Labels:

Affected Branches:
MOODLE_39_STABLE
Fixed Branches:
MOODLE_39_STABLE
Pull from Repository:
https://github.com/mackensen/moodle
Pull 3.9 Branch:
~~MDL-77128~~-39
Pull 3.9 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_39_STABLE...mackensen:moodle:MDL-77128-39
Testing Instructions:
Hide

Prerequisites: Clone the same version tester used in ~~MDL-59562~~

git clone git@github.com:Peterburnett/mdl-59562-tester.git admin/tool/versiontester

1) Start an upgrade from the web, and confirm on the 'Plugins check' step that you see the error 'Incompatible Moodle version: 39'

2) Run a CLI upgrade:

php admin/cli/upgrade.php

3) Verify that you see a message about failed dependency check:

Dependencies check failed for tool_versiontester

You must solve all the plugin requirements before proceeding to install this Moodle version!

4) Edit admin/tool/versiontester/version.php and change the incompatible declaration to `$plugin->incompatible = 410;`

5) Run a CLI upgrade again:

php admin/cli/upgrade.php

6) Verify that the upgrade continues and prompts for confirmation.
Show
Prerequisites: Clone the same version tester used in MDL-59562 git clone git @github .com:Peterburnett/mdl- 59562 -tester.git admin/tool/versiontester 1) Start an upgrade from the web, and confirm on the 'Plugins check' step that you see the error 'Incompatible Moodle version: 39' 2) Run a CLI upgrade: php admin/cli/upgrade.php 3) Verify that you see a message about failed dependency check: Dependencies check failed for tool_versiontester You must solve all the plugin requirements before proceeding to install this Moodle version! 4) Edit admin/tool/versiontester/version.php and change the incompatible declaration to `$plugin->incompatible = 410;` 5) Run a CLI upgrade again: php admin/cli/upgrade.php 6) Verify that the upgrade continues and prompts for confirmation.

Description

~~MDL-72324~~ was never applied to Moodle 3.9 and Moodle 3.10, which means that a plugin developer who's still supporting the LTS releases can't include a supported range starting at 39 and set the incompatible value, because unit tests on the MOODLE_39_STABLE will always fail (see for example https://github.com/LafColITS/moodle-local_remote_courses/actions/runs/4077464517).

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-77128.png
520 kB
20/Apr/23 12:36 PM

Issue Links

has a non-specific relationship to

MDL-72324 plugin incompatible check is backwards in upgradelib

Closed

Activity

People

Assignee:: Charles Fulton

Reporter:: Charles Fulton

Peer reviewer:: Paul Holden

Integrator:: Andrew Lyons

Tester:: Ron Carl Alfon Yu

Participants:: Andrew Lyons, Charles Fulton, CiBoT, Jake Dallimore, Mihail Geshoski, Paul Holden, Ron Carl Alfon Yu, Sara Arjona (@sarjona)

Votes:: 1 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 03/Feb/23 2:36 AM

Updated:: 22/Apr/23 2:27 AM

Resolved:: 22/Apr/23 2:27 AM

Fix Release Date:: 24/Apr/23

Time Tracking

Estimated:

Remaining:

Logged:

1h 12m