Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77132

Incorrect data providers

XMLWordPrintable

    • MOODLE_39_STABLE
    • MOODLE_39_STABLE
    • Hide
      1. Run the following:

        $ vendor/bin/phpunit message/tests/api_test.php
        $ vendor/bin/phpunit calendar/tests/externallib_test.php
        

      2. Confirm they both pass without warnings
      3. Confirm GHA run contains no further warnings regarding incorrect data provider notation
      Show
      Run the following: $ vendor/bin/phpunit message/tests/api_test.php $ vendor/bin/phpunit calendar/tests/externallib_test.php Confirm they both pass without warnings Confirm GHA run contains no further warnings regarding incorrect data provider notation

      This one is a follow up issue on https://tracker.moodle.org/browse/MDL-70070

       

      In 3.9,  we are getting following warnings. Looks like actual data providers haven't been renamed in https://github.com/moodle/moodle/blob/MOODLE_39_STABLE/calendar/tests/externallib_test.php#L2702 and https://github.com/moodle/moodle/blob/MOODLE_39_STABLE/message/tests/api_test.php#L6446
       
      There were 5 warnings:
       
      1) Warning
      The data provider specified for core_calendar_externallib_testcase::test_get_calendar_event_by_id_prevent_read_other_users_events is invalid.
      Method get_calendar_event_by_id_prevent_read_other_users_events_data_provider does not exist
       
      phpvfscomposer:///var/www/site/vendor/phpunit/phpunit/phpunit:60
       
      To re-run:
      vendor/bin/phpunit "PHPUnit\Framework\WarningTestCase" vendor/phpunit/phpunit/src/Framework/WarningTestCase.php
       
      2) Warning
      The data provider specified for core_calendar_externallib_testcase::test_delete_other_users_events is invalid.
      Method edit_or_delete_other_users_events_data_provider does not exist
       
      phpvfscomposer:///var/www/site/vendor/phpunit/phpunit/phpunit:60
       
      To re-run:
      vendor/bin/phpunit "PHPUnit\Framework\WarningTestCase" vendor/phpunit/phpunit/src/Framework/WarningTestCase.php
       
      3) Warning
      The data provider specified for core_calendar_externallib_testcase::test_edit_other_users_events is invalid.
      Method edit_or_delete_other_users_events_data_provider does not exist
       
      phpvfscomposer:///var/www/site/vendor/phpunit/phpunit/phpunit:60
       
      To re-run:
      vendor/bin/phpunit "PHPUnit\Framework\WarningTestCase" vendor/phpunit/phpunit/src/Framework/WarningTestCase.php
       
      4) Warning
      The data provider specified for core_message_api_testcase::test_get_conversation_counts is invalid.
      Method get_conversation_counts_test_cases does not exist
       
      phpvfscomposer:///var/www/site/vendor/phpunit/phpunit/phpunit:60
       
      To re-run:
      vendor/bin/phpunit "PHPUnit\Framework\WarningTestCase" vendor/phpunit/phpunit/src/Framework/WarningTestCase.php
       
      5) Warning
      The data provider specified for core_message_api_testcase::test_get_unread_conversation_counts is invalid.
      Method get_conversation_counts_test_cases does not exist
       
      phpvfscomposer:///var/www/site/vendor/phpunit/phpunit/phpunit:60

            pholden Paul Holden
            dmitriim Dmitrii Metelkin
            Simey Lameze Simey Lameze
            Andrew Lyons Andrew Lyons
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 47 minutes
                1h 47m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.