Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77137

curl multi method does not honour proxybypass option

    XMLWordPrintable

Details

    • Bug
    • Status: Waiting for peer review
    • Minor
    • Resolution: Unresolved
    • 4.1.1
    • None
    • Libraries
    • MOODLE_401_STABLE
    • 77137-proxybypass-on-multiple-curl-queries-master
    • Hide
      1. Go to Site administration > Reports > Security Checks > Checks all public / private paths (/report/security/index.php?detail=core_publicpaths)
        1. If the first 4 tests are not OK, rename your vendor/ and node_modules/ directories to something else
      2. Once the first 4 tests are OK, edit your config.php, and set the following variables at the end of file, just before require_once({}DIR{} . '/lib/setup.php'); :

        $CFG->proxyhost = 'i.do.not.exist';
        $CFG->proxybypass = parse_url($CFG->wwwroot, PHP_URL_HOST);
        

      3. Reload the page /report/security/index.php?detail=core_publicpaths

      Current result :
      The first test on vendor/ is red.

      Expected result :
      The first test on vendor/ should be green.

       

      Show
      Go to Site administration > Reports > Security Checks > Checks all public / private paths (/report/security/index.php?detail=core_publicpaths) If the first 4 tests are not OK, rename your vendor/ and node_modules/ directories to something else Once the first 4 tests are OK, edit your config.php, and set the following variables at the end of file, just before require_once( { }DIR{ } . '/lib/setup.php'); : $CFG ->proxyhost = 'i.do.not.exist' ; $CFG ->proxybypass = parse_url ( $CFG ->wwwroot, PHP_URL_HOST); Reload the page /report/security/index.php?detail=core_publicpaths Current result : The first test on vendor/ is red. Expected result : The first test on vendor/ should be green.  

    Description

      When HTTP proxy settings are configured, the curl class in filelib.php bypasses proxy settings if needed for a single query, but does not bypass HTTP proxy settings for a multiple queries if needed .

       

      Currently, the bypass setting is never applied to the first query. The next queries apply the parameter that should have been applied to the previous url.

      Attachments

        Issue Links

          Activity

            People

              jboulen Julien Boulen
              jboulen Julien Boulen
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: