-
Bug
-
Resolution: Fixed
-
Minor
-
4.0.6, 4.1
-
MOODLE_400_STABLE, MOODLE_401_STABLE
-
MOODLE_400_STABLE, MOODLE_401_STABLE
-
MDL-77150-401 -
Testing on master
Setup
- Download MDL-77150.diff
patch (to add some extra classes to system/custom reports) to your moodle root instance. - Apply the patch
git apply MDL-77150.diff - Log in as admin
- Navigate to Reports in user menu
- Create new report from Users report source, with default setup
Test custom attributes in a system report
- Navigate to Reports in user menu
- Confirm that the report background is displayed in orange colour
Test custom attributes in a custom report (view page)
- Navigate to Reports in user menu
- Click on View report option in the report action menu
- Confirm that the report background is displayed in orange colour
Test custom attributes in a custom report (edit page)
- Navigate to Reports in user menu
- Click on Edit report content option in the report action menu
- Confirm that the report background is not displayed in orange colour
Test custom attributes in a table column
- Navigate to Reports in user menu
- Confirm that the "Report source" column text is displayed in red colour
Testing on 4.0 / 4.1
Setup
- Download MDL-77150-backport.diff patch (to add some extra classes to reports list column) to your moodle root instance.
- Apply the patch
git apply MDL-77150-backport.diff - Log in as admin
- Navigate to Reports in user menu
- Create new report from Users report source, with default setup
Test custom attributes in a table column
- Navigate to Reports in user menu
- Confirm that the "Report source" column text is displayed in red colour
Testing on master Setup Download MDL-77150.diff patch (to add some extra classes to system/custom reports) to your moodle root instance. Apply the patch git apply MDL-77150.diff Log in as admin Navigate to Reports in user menu Create new report from Users report source, with default setup Test custom attributes in a system report Navigate to Reports in user menu Confirm that the report background is displayed in orange colour Test custom attributes in a custom report (view page) Navigate to Reports in user menu Click on View report option in the report action menu Confirm that the report background is displayed in orange colour Test custom attributes in a custom report (edit page) Navigate to Reports in user menu Click on Edit report content option in the report action menu Confirm that the report background is not displayed in orange colour Test custom attributes in a table column Navigate to Reports in user menu Confirm that the "Report source" column text is displayed in red colour Testing on 4.0 / 4.1 Setup Download MDL-77150-backport.diff patch (to add some extra classes to reports list column) to your moodle root instance. Apply the patch git apply MDL-77150-backport.diff Log in as admin Navigate to Reports in user menu Create new report from Users report source, with default setup Test custom attributes in a table column Navigate to Reports in user menu Confirm that the "Report source" column text is displayed in red colour - Download MDL-77150.diff
-
WP Sprint 2023-I1.2 (Paul)
In core_reportbuilder\local\report\column, the method add_attributes is supposed to handle "class" attributes too (to add custom classes to every cell in the column), but they are not being added to the DOM.
Also, In core_reportbuilder\local\report\base, the method add_attributes is supposed to handle "class" attributes too (to add custom classes to the report), but they are not being added to the DOM. (Only for 4.2)
