Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77174

Deprecate moodle-core-notification-confirm

    XMLWordPrintable

Details

    • MOODLE_402_STABLE
    • MOODLE_403_STABLE
    • MDL-77174-master
    • Hide

      Course move

      This drag/drop code is very buggy but this seems to be existing and is due for replacement already.

      1. Navigate to Site admin -> Courses -> Manage courses and categories
      2. Create a category structure as follows:

        - Root
        --- Science
        ----- Physics
        ----- Chemistry
        

      3. Create a course in the "Chemistry" category
      4. Navigate to the "Chemistry" category
      5. Drag/Drop the course into a different category
        1. Confirm that you are asked to confirm the move
      6. Press Cancel
        1. Confirm it did not move
      7. Repeat the drag/drop
        1. Confirm that you are asked to confirm the move
      8. Press "Move"
        1. Confirm that the course was moved into the new category

      Other users

      1. Navigate to a course
      2. Navigate to the Participants list
      3. Unenrol a user, making a note of which user they are
      4. From the "Tertiary navigation" dropdown, choose "Other users"
      5. Press "Assign roles"
      6. Select "Teacher"
      7. Find the user you just unenrolled and assign the role
      8. Press "Back" twice to get back to the "Other users" page
      9. Press the bin icon to remove the role assignment
        1. Confirm that you are asked to confirm the role removal
      10. Press Cancel
        1. Confirm it was not removed
      11. Press the bin icon to remove the role assignment
        1. Confirm that you are asked to confirm the role removal
      12. Press "Remove" to confirm the removal
        1. Confirm that the role was removed

      Quiz toolbox

      1. Navigate to a course
      2. Create a new quiz
      3. Create three questions on the course
      4. Lay them out with one question per page
      5. Between questions 2, and 3, add a Section from the dropdown
      6. Press "Select multiple items"
      7. Select just the third question
      8. Press "Delete selected"
        1. Confirm you are notified that you can't remove that question
      9. Select just the second question
      10. Press "Delete selected"
        1. Confirm you are shown a confirmation dialogue
      11. Press cancel
        1. Confirm it closed and the question remained
      12. Press "Delete selected"
        1. Confirm you are shown a confirmation dialogue
      13. Press "Yes"
        1. Confirm the question was removed after the page reload
      14. Add a new question to replace the one that was removed
      15. Press the "Bin" icon for that questiona gain
        1. Confirm you are shown a confirmation dialogue
      16. Press cancel
        1. Confirm it closed and the question remained
      17. Press "Delete selected"
        1. Confirm you are shown a confirmation dialogue
      18. Press "Yes"
        1. Confirm the question was removed after the page reload
      19. Press the "Delete section" bin icon
        1. Confirm you are shown a confirmation dialogue
      20. Press cancel
        1. Confirm it closed and the section remained
      21. Press "Delete selected"
        1. Confirm you are shown a confirmation dialogue
      22. Press "Yes"
        1. Confirm the section was removed after the page reload

      Quiz attempt

      1. As a student navigate to the quiz you created in the previous test
      2. Press the "Attempt quiz" button
      3. As teacher/admin view the quiz
      4. Follow the "Attempts: [count]" link
      5. Using the checkboxes, selet the attempt
      6. Press the "Delete selected attempts" button
        1. Confirm you are shown a confirmation dialogue
      7. Press cancel
        1. Confirm it closed and the attempt remained
      8. Press "Delete selected"
        1. Confirm you are shown a confirmation dialogue
      9. Press "Yes"
        1. Confirm the attempt was removed after the page reload

      Deprecation notices

      1. Open the quiz page in Moodle
      2. Press "F12" to get the Developer tools
      3. Open the JS console
      4. Create a new legacy confirmation:

        new M.core.confirm({})
        

        1. Confirm you were shown a deprecation notice in the console

      Payment

      1. Navigate to Site admin -> Payments -> Payment accounts
      2. Create an account:
        1. Account name: "Example"
      3. From the "Edit" menu, choose "Delete or archive"
        1. Confirm you are shown a confirmation dialogue
      4. Press cancel
        1. Confirm it closed and the account remained
      5. Press the same link again
        1. Confirm you are shown a confirmation dialogue
      6. Press "Yes"
        1. Confirm the account was removed after the page reload

      Advanced grading - Marking guide

      1. Create a new "Assignment" activity
      2. Under "Grade" > "Grading method" choose "Marking guide"
      3. Go to "Advanced grading" in the assignment secondary navigation and create a new guide from scratch
      4. Scroll down to the criterion and "Add criterion"
      5. Immediately try to delete it using the "X" link
        1. Confirm you are shown a confirmation dialogue
      6. Press cancel
        1. Confirm it closed and the criterion remained
      7. Press the same link again
        1. Confirm you are shown a confirmation dialogue
      8. Press "Yes"
        1. Confirm the criterion was removed

      Advanced grading - Rubric

      1. Create a new "Assignment" activity
      2. Under "Grade" > "Grading method" choose "Rubric"
      3. Go to "Advanced grading" in the assignment secondary navigation and create a guide from scratch
      4. Scroll down to the criterion and "Add criterion"
      5. Click the "X" link on a Level within the new criterion
        1. Confirm you are shown a confirmation dialogue
      6. Press cancel
        1. Confirm it closed and the level remained
      7. Press the same link again
        1. Confirm you are shown a confirmation dialogue
      8. Press "Yes"
        1. Confirm the level was removed
      9. Immediately try to delete it using the "X" link
        1. Confirm you are shown a confirmation dialogue
      10. Press cancel
        1. Confirm it closed and the criterion remained
      11. Press the same link again
        1. Confirm you are shown a confirmation dialogue
      12. Press "Yes"
        1. Confirm the criterion was removed

      File manager

      1. Navigate to your dashboard
      2. From the "Private files" block, select "Manage private files..."
      3. Upload some files
      4. Create a folder
      5. Upload some files into the folder
      6. Save changes
      7. Re-open the modal again
      8. Click on one of the files
        1. Confirm a file information modal was opened
      9. Press the "Delete" button
        1. Confirm you are shown a confirmation dialogue
      10. Press cancel
        1. Confirm it closed and the item remained
      11. Press the same button again
        1. Confirm you are shown a confirmation dialogue
      12. Press "Yes"
        1. Confirm the item was removed
      13. Click on the folder's kebab menu
        1. Confirm a file information modal was opened
      14. Rename the folder and press "Update"
        1. Confirm you are shown a confirmation dialogue
      15. Press cancel
        1. Confirm it closed and the item waas unchanged
      16. Press the same button again
        1. Confirm you are shown a confirmation dialogue
      17. Press "Yes"
        1. Confirm the item was renamed
      18. Repen the File info for that folder
      19. Press the "Delete" button"
        1. Confirm you are shown a confirmation dialogue
      20. Press cancel
        1. Confirm it closed and the item remained
      21. Press the same button again
        1. Confirm you are shown a confirmation dialogue
      22. Press "Yes"
        1. Confirm the item was removed
      Show
      Course move This drag/drop code is very buggy but this seems to be existing and is due for replacement already. Navigate to Site admin -> Courses -> Manage courses and categories Create a category structure as follows: - Root --- Science ----- Physics ----- Chemistry Create a course in the "Chemistry" category Navigate to the "Chemistry" category Drag/Drop the course into a different category Confirm that you are asked to confirm the move Press Cancel Confirm it did not move Repeat the drag/drop Confirm that you are asked to confirm the move Press "Move" Confirm that the course was moved into the new category Other users Navigate to a course Navigate to the Participants list Unenrol a user, making a note of which user they are From the "Tertiary navigation" dropdown, choose "Other users" Press "Assign roles" Select "Teacher" Find the user you just unenrolled and assign the role Press "Back" twice to get back to the "Other users" page Press the bin icon to remove the role assignment Confirm that you are asked to confirm the role removal Press Cancel Confirm it was not removed Press the bin icon to remove the role assignment Confirm that you are asked to confirm the role removal Press "Remove" to confirm the removal Confirm that the role was removed Quiz toolbox Navigate to a course Create a new quiz Create three questions on the course Lay them out with one question per page Between questions 2, and 3, add a Section from the dropdown Press "Select multiple items" Select just the third question Press "Delete selected" Confirm you are notified that you can't remove that question Select just the second question Press "Delete selected" Confirm you are shown a confirmation dialogue Press cancel Confirm it closed and the question remained Press "Delete selected" Confirm you are shown a confirmation dialogue Press "Yes" Confirm the question was removed after the page reload Add a new question to replace the one that was removed Press the "Bin" icon for that questiona gain Confirm you are shown a confirmation dialogue Press cancel Confirm it closed and the question remained Press "Delete selected" Confirm you are shown a confirmation dialogue Press "Yes" Confirm the question was removed after the page reload Press the "Delete section" bin icon Confirm you are shown a confirmation dialogue Press cancel Confirm it closed and the section remained Press "Delete selected" Confirm you are shown a confirmation dialogue Press "Yes" Confirm the section was removed after the page reload Quiz attempt As a student navigate to the quiz you created in the previous test Press the "Attempt quiz" button As teacher/admin view the quiz Follow the "Attempts: [count] " link Using the checkboxes, selet the attempt Press the "Delete selected attempts" button Confirm you are shown a confirmation dialogue Press cancel Confirm it closed and the attempt remained Press "Delete selected" Confirm you are shown a confirmation dialogue Press "Yes" Confirm the attempt was removed after the page reload Deprecation notices Open the quiz page in Moodle Press "F12" to get the Developer tools Open the JS console Create a new legacy confirmation: new M.core.confirm({}) Confirm you were shown a deprecation notice in the console Payment Navigate to Site admin -> Payments -> Payment accounts Create an account: Account name: "Example" From the "Edit" menu, choose "Delete or archive" Confirm you are shown a confirmation dialogue Press cancel Confirm it closed and the account remained Press the same link again Confirm you are shown a confirmation dialogue Press "Yes" Confirm the account was removed after the page reload Advanced grading - Marking guide Create a new "Assignment" activity Under "Grade" > "Grading method" choose "Marking guide" Go to "Advanced grading" in the assignment secondary navigation and create a new guide from scratch Scroll down to the criterion and "Add criterion" Immediately try to delete it using the "X" link Confirm you are shown a confirmation dialogue Press cancel Confirm it closed and the criterion remained Press the same link again Confirm you are shown a confirmation dialogue Press "Yes" Confirm the criterion was removed Advanced grading - Rubric Create a new "Assignment" activity Under "Grade" > "Grading method" choose "Rubric" Go to "Advanced grading" in the assignment secondary navigation and create a guide from scratch Scroll down to the criterion and "Add criterion" Click the "X" link on a Level within the new criterion Confirm you are shown a confirmation dialogue Press cancel Confirm it closed and the level remained Press the same link again Confirm you are shown a confirmation dialogue Press "Yes" Confirm the level was removed Immediately try to delete it using the "X" link Confirm you are shown a confirmation dialogue Press cancel Confirm it closed and the criterion remained Press the same link again Confirm you are shown a confirmation dialogue Press "Yes" Confirm the criterion was removed File manager Navigate to your dashboard From the "Private files" block, select "Manage private files..." Upload some files Create a folder Upload some files into the folder Save changes Re-open the modal again Click on one of the files Confirm a file information modal was opened Press the "Delete" button Confirm you are shown a confirmation dialogue Press cancel Confirm it closed and the item remained Press the same button again Confirm you are shown a confirmation dialogue Press "Yes" Confirm the item was removed Click on the folder's kebab menu Confirm a file information modal was opened Rename the folder and press "Update" Confirm you are shown a confirmation dialogue Press cancel Confirm it closed and the item waas unchanged Press the same button again Confirm you are shown a confirmation dialogue Press "Yes" Confirm the item was renamed Repen the File info for that folder Press the "Delete" button" Confirm you are shown a confirmation dialogue Press cancel Confirm it closed and the item remained Press the same button again Confirm you are shown a confirmation dialogue Press "Yes" Confirm the item was removed
    • 6

    Description

      Remove all uses of moodle-core-notification-confirm and M.core.confirm and replace with AMD.
      M.util.show_confirm_dialog uses this under the hood, but should also be deprecated in the long run.

      • Update M.util.show_confirm_dialog to use the core/notification modal
      • deprecate the YUI module
      • update all users of it

      Attachments

        1. (I) 5 Passed -- (Master)MDL-77174.png
          (I) 5 Passed -- (Master)MDL-77174.png
          97 kB
        2. (I) 6 Passed -- (Master)MDL-77174.png
          (I) 6 Passed -- (Master)MDL-77174.png
          81 kB
        3. (I) 7 Passed -- (Master)MDL-77174.png
          (I) 7 Passed -- (Master)MDL-77174.png
          102 kB
        4. (I) 8 Passed -- (Master)MDL-77174.png
          (I) 8 Passed -- (Master)MDL-77174.png
          84 kB
        5. (II) 10 Passed -- (Master)MDL-77174.png
          (II) 10 Passed -- (Master)MDL-77174.png
          57 kB
        6. (II) 11 Passed -- (Master)MDL-77174.png
          (II) 11 Passed -- (Master)MDL-77174.png
          60 kB
        7. (II) 12 Passed -- (Master)MDL-77174.png
          (II) 12 Passed -- (Master)MDL-77174.png
          51 kB
        8. (II) 9 Passed -- (Master)MDL-77174.png
          (II) 9 Passed -- (Master)MDL-77174.png
          60 kB
        9. (III) 10 Passed -- (Master)MDL-77174.png
          (III) 10 Passed -- (Master)MDL-77174.png
          83 kB
        10. (III) 11 Passed -- (Master)MDL-77174.png
          (III) 11 Passed -- (Master)MDL-77174.png
          77 kB
        11. (III) 12 Passed -- (Master)MDL-77174.png
          (III) 12 Passed -- (Master)MDL-77174.png
          85 kB
        12. (III) 13 Passed -- (Master)MDL-77174.png
          (III) 13 Passed -- (Master)MDL-77174.png
          87 kB
        13. (III) 15 Passed -- (Master)MDL-77174.png
          (III) 15 Passed -- (Master)MDL-77174.png
          84 kB
        14. (III) 16 Passed -- (Master)MDL-77174.png
          (III) 16 Passed -- (Master)MDL-77174.png
          75 kB
        15. (III) 17 Passed -- (Master)MDL-77174.png
          (III) 17 Passed -- (Master)MDL-77174.png
          80 kB
        16. (III) 18 Passed -- (Master)MDL-77174.png
          (III) 18 Passed -- (Master)MDL-77174.png
          64 kB
        17. (III) 19 Passed -- (Master)MDL-77174.png
          (III) 19 Passed -- (Master)MDL-77174.png
          74 kB
        18. (III) 20 Passed -- (Master)MDL-77174.png
          (III) 20 Passed -- (Master)MDL-77174.png
          66 kB
        19. (III) 21 Passed -- (Master)MDL-77174.png
          (III) 21 Passed -- (Master)MDL-77174.png
          81 kB
        20. (III) 22 Passed -- (Master)MDL-77174.png
          (III) 22 Passed -- (Master)MDL-77174.png
          80 kB
        21. (III) 8 Passed -- (Master)MDL-77174.png
          (III) 8 Passed -- (Master)MDL-77174.png
          101 kB
        22. (IV) 6 Passed -- (Master)MDL-77174.png
          (IV) 6 Passed -- (Master)MDL-77174.png
          93 kB
        23. (IV) 7 Passed -- (Master)MDL-77174.png
          (IV) 7 Passed -- (Master)MDL-77174.png
          94 kB
        24. (IV) 8 Passed -- (Master)MDL-77174.png
          (IV) 8 Passed -- (Master)MDL-77174.png
          104 kB
        25. (IV) 9 Passed -- (Master)MDL-77174.png
          (IV) 9 Passed -- (Master)MDL-77174.png
          84 kB
        26. (IX) 10 Passed -- (Master)MDL-77174.png
          (IX) 10 Passed -- (Master)MDL-77174.png
          62 kB
        27. (IX) 11 Passed -- (Master)MDL-77174.png
          (IX) 11 Passed -- (Master)MDL-77174.png
          59 kB
        28. (IX) 12 Passed -- (Master)MDL-77174.png
          (IX) 12 Passed -- (Master)MDL-77174.png
          48 kB
        29. (IX) 13 Passed -- (Master)MDL-77174.png
          (IX) 13 Passed -- (Master)MDL-77174.png
          59 kB
        30. (IX) 14 Passed -- (Master)MDL-77174.png
          (IX) 14 Passed -- (Master)MDL-77174.png
          59 kB
        31. (IX) 15 Passed -- (Master)MDL-77174.png
          (IX) 15 Passed -- (Master)MDL-77174.png
          49 kB
        32. (IX) 16 Passed -- (Master)MDL-77174.png
          (IX) 16 Passed -- (Master)MDL-77174.png
          59 kB
        33. (IX) 17 Passed -- (Master)MDL-77174.png
          (IX) 17 Passed -- (Master)MDL-77174.png
          49 kB
        34. (IX) 19 Passed -- (Master)MDL-77174.png
          (IX) 19 Passed -- (Master)MDL-77174.png
          65 kB
        35. (IX) 20 Passed -- (Master)MDL-77174.png
          (IX) 20 Passed -- (Master)MDL-77174.png
          64 kB
        36. (IX) 21 Passed -- (Master)MDL-77174.png
          (IX) 21 Passed -- (Master)MDL-77174.png
          57 kB
        37. (IX) 22 Passed -- (Master)MDL-77174.png
          (IX) 22 Passed -- (Master)MDL-77174.png
          53 kB
        38. (IX) 8 Passed -- (Master)MDL-77174.png
          (IX) 8 Passed -- (Master)MDL-77174.png
          107 kB
        39. (IX) 9 Passed -- (Master)MDL-77174.png
          (IX) 9 Passed -- (Master)MDL-77174.png
          62 kB
        40. (V) 4 Passed -- (Master)MDL-77174.png
          (V) 4 Passed -- (Master)MDL-77174.png
          165 kB
        41. (VI) 3 Passed -- (Master)MDL-77174.png
          (VI) 3 Passed -- (Master)MDL-77174.png
          76 kB
        42. (VI) 4 Passed -- (Master)MDL-77174.png
          (VI) 4 Passed -- (Master)MDL-77174.png
          60 kB
        43. (VI) 5 Passed -- (Master)MDL-77174.png
          (VI) 5 Passed -- (Master)MDL-77174.png
          76 kB
        44. (VI) 6 Passed -- (Master)MDL-77174.png
          (VI) 6 Passed -- (Master)MDL-77174.png
          57 kB
        45. (VII) 5 Passed -- (Master)MDL-77174.png
          (VII) 5 Passed -- (Master)MDL-77174.png
          94 kB
        46. (VII) 6 Passed -- (Master)MDL-77174.png
          (VII) 6 Passed -- (Master)MDL-77174.png
          82 kB
        47. (VII) 7 Passed -- (Master)MDL-77174.png
          (VII) 7 Passed -- (Master)MDL-77174.png
          94 kB
        48. (VII) 8 Passed -- (Master)MDL-77174.png
          (VII) 8 Passed -- (Master)MDL-77174.png
          74 kB
        49. (VIII) 10 Passed -- (Master)MDL-77174.png
          (VIII) 10 Passed -- (Master)MDL-77174.png
          85 kB
        50. (VIII) 11 Passed -- (Master)MDL-77174.png
          (VIII) 11 Passed -- (Master)MDL-77174.png
          89 kB
        51. (VIII) 12 Passed -- (Master)MDL-77174.png
          (VIII) 12 Passed -- (Master)MDL-77174.png
          91 kB
        52. (VIII) 5 Passed -- (Master)MDL-77174.png
          (VIII) 5 Passed -- (Master)MDL-77174.png
          91 kB
        53. (VIII) 6 Passed -- (Master)MDL-77174.png
          (VIII) 6 Passed -- (Master)MDL-77174.png
          84 kB
        54. (VIII) 7 Passed -- (Master)MDL-77174.png
          (VIII) 7 Passed -- (Master)MDL-77174.png
          87 kB
        55. (VIII) 8 Passed -- (Master)MDL-77174.png
          (VIII) 8 Passed -- (Master)MDL-77174.png
          84 kB
        56. (VIII) 9 Passed -- (Master)MDL-77174.png
          (VIII) 9 Passed -- (Master)MDL-77174.png
          86 kB

        Issue Links

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Andrew Lyons Andrew Lyons
              Jun Pataleta Jun Pataleta
              Kim Jared Lucas Kim Jared Lucas
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 days, 3 hours, 49 minutes
                  3d 3h 49m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.