Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 4.4.6, 4.5.2
Affects Version/s: 4.2.8, STABLE backlog, 4.1.1, 4.1.11, 4.3.5, 4.4, 4.4.1
Component/s: Libraries
Labels:
- ci
- hqteam_hedgehog
- patch
- release_notes
- triaged

Affected Branches:
MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/leonstr/moodle
Pull 4.4 Branch:
~~MDL-77185~~-diskfreespace-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...leonstr:moodle:MDL-77185-diskfreespace-404
Pull 4.5 Branch:
~~MDL-77185~~-diskfreespace-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...leonstr:moodle:MDL-77185-diskfreespace-405
Pull Main Branch:
~~MDL-77185~~-diskfreespace
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...leonstr:moodle:MDL-77185-diskfreespace
Testing Instructions:
Hide

Open config.php and add the below codes:

$CFG->session_handler_class = '\core\session\file';

$CFG->session_file_save_path = $CFG->dataroot.'/sessions';

Setup your hosting to use PHP 8.0 or greater.

Setup your hosting php.ini to disable the function disk_free_space (disable_functions).

disable_functions = disk_free_space

Restart your webserver to update php settings and try access to Moodle.

VERIFY that there is no error "Exception - Call to undefined function core\session\disk_free_space()"
Show
Open config.php and add the below codes: $CFG->session_handler_class = '\core\session\file' ; $CFG->session_file_save_path = $CFG->dataroot. '/sessions' ; Setup your hosting to use PHP 8.0 or greater. Setup your hosting php.ini to disable the function disk_free_space (disable_functions). disable_functions = disk_free_space Restart your webserver to update php settings and try access to Moodle. VERIFY that there is no error "Exception - Call to undefined function core\session\disk_free_space()"
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-77185~~ using repository: https://github.com/leonstr/moodle

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-77185-diskfreespace-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-77185-diskfreespace-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-77185-diskfreespace | CI Job]

_{More information about this report}

Built on: Sat Jan 4 04:28:35 AM UTC 2025
Show
Code verified against automated checks. Checked MDL-77185 using repository: https://github.com/leonstr/moodle MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-77185-diskfreespace-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-77185-diskfreespace-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-77185-diskfreespace | CI Job ] More information about this report Built on: Sat Jan 4 04:28:35 AM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-77185~~-diskfreespace-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17803/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60632/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60633/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-77185~~-diskfreespace-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17804/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60634/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60635/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-77185~~-diskfreespace

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17805/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60636/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60637/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60638/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60639/ App tests (stable app version)

Built on: Sat Jan 4 04:25:23 AM UTC 2025
Show
Launching automatic jobs for branch MDL-77185 -diskfreespace-404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17803/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60632/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60633/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-77185 -diskfreespace-405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17804/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60634/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60635/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-77185 -diskfreespace https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17805/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60636/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60637/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60638/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60639/ App tests (stable app version) Built on: Sat Jan 4 04:25:23 AM UTC 2025

Description

When using PHP 8+ with the function "disk_free_space" disabled, this throws the following error:

Exception - Call to undefined function core\session\disk_free_space()

Cause

The error handling of the "@" character has changed with PHP 8 and PHP 8.1. If functions are addressed that are deactivated on the server side, a fatal error occurs even if this function is provided with an "@".

In this case, it happens in the following file:

/lib/classes/session/file.php:67

$freespace = @disk_free_space($this->sessiondir);

Solution

in PHP 8+ we must check the function with "function_exists" implicit and not use "@", because in shared hosting some php functions could be disabled.

Change the mentioned line code with:

$freespace = function_exists('disk_free_space') ? disk_free_space($this->sessiondir) : false;

Github Compare for pull-request: https://github.com/moodle/moodle/compare/main...fedealvz:moodle:main

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 5 Passed -- (Main)MDL-77185.png
122 kB
09/Jan/25 1:27 PM

has a non-specific relationship to

MDL-43039 "The session partition is full.": false positive

Closed

has been marked as being related by

MDL-84088 PR only: MDL-77185 - PHP 8 error when disk_free_space function is disabled

Closed

Assignee:: Leon Stringer

Reporter:: Federico Alvarez

Peer reviewer:: Meirza

Integrator:: Huong Nguyen

Tester:: Kim Jared Lucas

Participants:: CiBoT, Federico Alvarez, Huong Nguyen, Kim Jared Lucas, Leon Stringer, Luca Bösch, Meirza

Votes:: 2 Vote for this issue

Watchers:: 18 Start watching this issue

Created:: 09/Feb/23 6:04 AM

Updated:: 07/Feb/25 1:07 PM

Resolved:: 09/Jan/25 10:39 PM

Estimated:

Remaining:

Logged:

41m

Details

Description

Description

Cause

Solution

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify