-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
4.1.1
-
MOODLE_401_STABLE
-
MDL-77237_401_STABLE
-
MDL-77237_403_STABLE
-
MDL-77237_master
-
Testing while upgrading
- Do not apply the patch yet
- Install the previous stable version of Moodle (latest stable release on the previous branch).
- Set the debugging level to DEVELOPER. Make sure you can see errors (display them on screen or monitor the error log).
- Set it up with some courses, users and content. Using the 'Make test course' feature in the Site administration is a quick way to achieve this.
- Upgrade the code to this current version of Moodle you are testing.
- Apply the patch
- Visit /admin and go through the upgrade process.
- VERIFY that the upgrade process completes without any errors.
Testing while not upgrading
- Download MDL-77237-test.php
and put the file in your Moodle root directory. - Open the browser and access the file with the URL http://wwwroot/MDL-77237-test.php
- VERIFY that you see errors like the following
The capability 'mod/data:managecomments' is deprecated.This capability should not be used anymore.
line 2623 of /lib/accesslib.php: call to debugging()
line 5 of /MDL-77237-test.php: call to get_capability_info()
The capability 'tiny/premium:accesspremium' is deprecated.This capability has been renamedIt will be replaced by 'tiny/premium:use'.
line 2623 of /lib/accesslib.php: call to debugging()
line 6 of /MDL-77237-test.php: call to get_capability_info()
stdClass Object ( [id] => 756 [name] => tiny/premium:use [captype] => read [contextlevel] => 30 [component] => tiny_premium [riskbitmask] => 0 )
Testing while upgrading Do not apply the patch yet Install the previous stable version of Moodle (latest stable release on the previous branch). Set the debugging level to DEVELOPER. Make sure you can see errors (display them on screen or monitor the error log). Set it up with some courses, users and content. Using the 'Make test course' feature in the Site administration is a quick way to achieve this. Upgrade the code to this current version of Moodle you are testing. Apply the patch Visit /admin and go through the upgrade process. VERIFY that the upgrade process completes without any errors. Testing while not upgrading Download MDL-77237-test.php and put the file in your Moodle root directory. Open the browser and access the file with the URL http://wwwroot/MDL-77237-test.php VERIFY that you see errors like the following The capability 'mod/data:managecomments' is deprecated.This capability should not be used anymore. line 2623 of /lib/accesslib.php: call to debugging() line 5 of /MDL- 77237 -test.php: call to get_capability_info() The capability 'tiny/premium:accesspremium' is deprecated.This capability has been renamedIt will be replaced by 'tiny/premium:use' . line 2623 of /lib/accesslib.php: call to debugging() line 6 of /MDL- 77237 -test.php: call to get_capability_info() stdClass Object ( [id] => 756 [name] => tiny/premium:use [captype] => read [contextlevel] => 30 [component] => tiny_premium [riskbitmask] => 0 ) -
Code verified against automated checks. 
Checked MDL-77237 using repository: https://github.com/meirzamoodle/moodle.git
MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-77237-404 | CI Job]- MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-77237-405 | CI Job]
- main (0 errors / 0 warnings) [branch: MDL-77237-main | CI Job]
More information about this report
Built on: Mon Apr 7 05:58:18 UTC 2025
Code verified against automated checks. Checked MDL-77237 using repository: https://github.com/meirzamoodle/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-77237-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-77237-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-77237-main | CI Job ] More information about this report Built on: Mon Apr 7 05:58:18 UTC 2025 -
-
6
-
Team Dragons 2025 Sprint 1.3, Team Hedgehogs 2025 Sprint 2.0, Team Hedgehogs 2025 Sprint 2.1
This is caused by MDL-55580, specifically the late decision to move all the debugging output to the function get_capability_info(). This results in debugging during upgrade even despite the fact that neither has_capability, require_capability(), etc. are called.
See the example on MDL-72066, where we deprecate the capability as per the documentation added in MDL-55580. See that here: https://moodledev.io/docs/apis/subsystems/access#deprecating-a-capability
Once the capability has been deprecated, run the upgrade (with debugging enabled) and you'll see the following:
The capability 'mod/lti:manage' is deprecated.This was replaced by the |
more specific mod/lti:instructor, mod/lti:teachingassistant and
|
mod/lti:managerIt will be replaced by 'mod/lti:instructor'.line 2581 of /lib/accesslib.php: call to debugging()line 1468 of /lib/accesslib.php: call to get_capability_info()line 2428 of /lib/accesslib.php: call to unassign_capability()line 2393 of /lib/accesslib.php: call to capabilities_cleanup()line 638 of /lib/upgradelib.php: call to update_capabilities()line 953 of /lib/upgradelib.php: call to upgrade_component_updated()line 677 of /lib/upgradelib.php: call to upgrade_plugins_modules()line 1952 of /lib/upgradelib.php: call to upgrade_plugins()line 721 of /admin/index.php: call to upgrade_noncore() |
This will occur n times - once for each role archetype the capability was included with. In the linked example, this is seen 3 times for mod/lti upgrade.
I think this needs addressing. This isn't a problem with anything in the upgrade. It's behaving normally by cleaning up caps and shouldn't throw debugging. We only want debugging when a deprecated capability is being called.
- Discovered while testing
-
MDL-72066 Ability to pass through specific LTI roles to tool provider
-
- Development in progress
-
-
MDLQA-19906
CLONE - This version upgrades without errors from the previous version
-
- Passed
-
- has a non-specific relationship to
-
-
- Closed
-
