[MDL-77278] Fix sticky footer in Firefox - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_402_STABLE
Fixed Branches:
MOODLE_402_STABLE
Pull from Repository:
https://github.com/ferranrecio/moodle.git
Pull Master Branch:
~~MDL-77278~~-master
Pull Master Diff URL:
https://github.com/ferranrecio/moodle/compare/8503f2cfd8...MDL-77278-master
Testing Instructions:
Hide

Open Firefox

Login as admin

Access a course

Turn edit on

Check the sticky footer is not visible at the bottom of the page

Click on the "Bulk edit" button near the course title

Check the sticky footer is visible at the bottom of the page

Click the X icon in the sticky footer (Close bulk edit)

Check the sticky footer is not visible at the bottom of the page
Show
Open Firefox Login as admin Access a course Turn edit on Check the sticky footer is not visible at the bottom of the page Click on the "Bulk edit" button near the course title Check the sticky footer is visible at the bottom of the page Click the X icon in the sticky footer (Close bulk edit) Check the sticky footer is not visible at the bottom of the page

It looks like the new sticky footer height introduced in ~~MDL-76357~~ is not working as expected in firefox.

The errors are related to the clamp CSS functions that define the sticky footer height depending on the font size.

$stickyfooter-height: clamp(96px, calc(#{$font-size-base} * 3), calc(#{$font-size-base} * 3)) !default;

This clamp calculation can be replaced by:

$stickyfooter-height: calc(max(96px, calc(#{$font-size-base} * 3))) !default;

Participants:: Andrew Lyons, CiBoT, Ferran Recio, Kim Jared Lucas, Paul Holden

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona), Huong Nguyen, Bas Brands, Mathew May, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Estimated:

Remaining:

Logged:

1h 17m