Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77307

Final deprecation grader report and grade functions deprecated in Moodle <= 4.2

XMLWordPrintable

    • MOODLE_402_STABLE, MOODLE_500_STABLE
    • MOODLE_501_STABLE
    • MDL-77307_final-deprecation-grader-report-and-grade-functions
    • Hide
      1. Run the following commands:

        git grep -C2 'get_grade_analysis_icon('
        git grep -C2 'get_reset_icon('
        git grep -C2 'get_edit_icon('
        git grep -C2 'get_hiding_icon('
        git grep -C2 'get_locking_icon('
        git grep -C2 'get_calculation_icon('
        

      2. Verify it only returns the deprecated function stubs.
      3. Run the following commands:

        git grep -C2 'get_left_icons_row('
        git grep -C2 'get_right_icons_row('
        git grep -C2 'get_icons(' -- ':!mod/data'
        

      4. Verify it only returns the deprecated function stubs, possible mentions in upgrade.txt or UPGRADING.md (there may be false positives)
      5. Run the following commands:

        git grep 'editverbose,core_grades'
        git grep 'showverbose,core_grades'
        git grep 'hideverbose,core_grades'
        git grep 'hiddenuntildate,core_grades'
        git grep 'unlockverbose,core_grades'
        git grep 'nonunlockableverbose,core_grades'
        git grep 'locktimedate,core_grades'
        git grep 'editcalculationverbose,core_grades'
        

      6. Verify it only returns the deprecated langstrings and possible mentions in upgrade.txt or UPGRADING.md
      Show
      Run the following commands: git grep -C2 'get_grade_analysis_icon(' git grep -C2 'get_reset_icon(' git grep -C2 'get_edit_icon(' git grep -C2 'get_hiding_icon(' git grep -C2 'get_locking_icon(' git grep -C2 'get_calculation_icon(' Verify it only returns the deprecated function stubs. Run the following commands: git grep -C2 'get_left_icons_row(' git grep -C2 'get_right_icons_row(' git grep -C2 'get_icons(' -- ':!mod/data' Verify it only returns the deprecated function stubs, possible mentions in upgrade.txt or UPGRADING.md (there may be false positives) Run the following commands: git grep 'editverbose,core_grades' git grep 'showverbose,core_grades' git grep 'hideverbose,core_grades' git grep 'hiddenuntildate,core_grades' git grep 'unlockverbose,core_grades' git grep 'nonunlockableverbose,core_grades' git grep 'locktimedate,core_grades' git grep 'editcalculationverbose,core_grades' Verify it only returns the deprecated langstrings and possible mentions in upgrade.txt or UPGRADING.md
    • Hide

      Code verified against automated checks.

      Checked MDL-77307 using repository: https://github.com/ziegenberg/moodle

      More information about this report

      Built on: Wed Apr 30 20:06:38 UTC 2025

      Show
      Code verified against automated checks. Checked MDL-77307 using repository: https://github.com/ziegenberg/moodle main (0 errors / 0 warnings) [branch: MDL-77307_final-deprecation-grader-report-and-grade-functions | CI Job ] More information about this report Built on: Wed Apr 30 20:06:38 UTC 2025

      These functions need to be removed:

      grade/lib.php:

      • get_grade_analysis_icon
      • get_reset_icon
      • get_edit_icon
      • get_hiding_icon
      • get_locking_icon
      • get_calculation_icon

      grade/report/lib.php:

      grade/report/grader/lib.php:

      • get_left_icons_row
      • get_right_icons_row
      • get_icons

       

            Daniel Ziegenberg Daniel Ziegenberg
            ilyatregubov Ilya Tregubov
            Paul Holden Paul Holden
            Glyn (Mathew) May Glyn (Mathew) May
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 5 minutes
                1h 5m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.