Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77308

Remove the legacy TinyMCE editor from core (editor_tinymce)

XMLWordPrintable

    • MOODLE_402_STABLE
    • MOODLE_402_STABLE
    • MDL-77308-master
    • Hide

      Removing the docs_required label as this was documented in https://docs.moodle.org/402/en/Upgrading

      Show
      Removing the docs_required label as this was documented in https://docs.moodle.org/402/en/Upgrading
    • Hide

      Test setup

      1. Create a new site and ensure that it does NOT include this change
        The easiest way to do this would be:

        mdk create --name mdl77308 -i -e pgsql
        

      2. Navigate to site administration > Plugins > Text editors > Manage editors
      3. Enable the Legacy TinyMCE editor
      4. Put it near the top of the list
      5. Open the user menu > Prefences page
      6. Open the Editor preferences
      7. Choose the Legacy TIny editor
      8. Now switch to the integration code:

        git remote add integration ~/.moodle-sdk/integration.git
        git fetch integration
        git reset --hard integration/master
        

      Test that the editor is not removed if it is still present

      1. Clone the plugin code back to it's old location:

        git clone https://github.com/moodlehq/moodle-editor_tinymce lib/editor/tinymce
        

      2. Run the upgrade
      3. Navigate to site administration > Plugins > Text editors > Manage text editors
        1. Confirm that the Legacy TinyMCE editor is still enabled
        2. Confirm that it is in the same order as before
      4. Open the user menu > Prefences page
      5. Open the Editor preferences
        1. Confirm that your preference is still set to TinyMCE

      Removal test

      1. Reset your branch to the code before removal. If you've followed the instructions so far that should be:

        rm -rf lib/editor/tinymce
        git reset --hard origin/master
        

      2. Run the version resetter:

        mdk run version
        php admin/cli/upgrade.php
        

      3. Check out the code under test again

        git reset --hard integration/master
        

        1. Confirm that TinyMCE is no longer present:

          # The following should error:
          ls -l lib/editor/tinymce
          

      4. Run the upgrade again
      5. Navigate to site administration > Plugins > Text editors > Manage text editors
        1. Confirm that the Legacy TinyMCE editor is no longer present
        2. Confirm that you can move the top editor down the list
      6. Open the user menu > Prefences page
      7. Open the Editor preferences
        1. Confirm that your preference is now set to the Default editor
      Show
      Test setup Create a new site and ensure that it does NOT include this change The easiest way to do this would be: mdk create --name mdl77308 -i -e pgsql Navigate to site administration > Plugins > Text editors > Manage editors Enable the Legacy TinyMCE editor Put it near the top of the list Open the user menu > Prefences page Open the Editor preferences Choose the Legacy TIny editor Now switch to the integration code: git remote add integration ~/.moodle-sdk/integration.git git fetch integration git reset --hard integration/master Test that the editor is not removed if it is still present Clone the plugin code back to it's old location: git clone https://github.com/moodlehq/moodle-editor_tinymce lib/editor/tinymce Run the upgrade Navigate to site administration > Plugins > Text editors > Manage text editors Confirm that the Legacy TinyMCE editor is still enabled Confirm that it is in the same order as before Open the user menu > Prefences page Open the Editor preferences Confirm that your preference is still set to TinyMCE Removal test Reset your branch to the code before removal. If you've followed the instructions so far that should be: rm -rf lib/editor/tinymce git reset --hard origin/master Run the version resetter: mdk run version php admin/cli/upgrade.php Check out the code under test again git reset --hard integration/master Confirm that TinyMCE is no longer present: # The following should error: ls -l lib/editor/tinymce Run the upgrade again Navigate to site administration > Plugins > Text editors > Manage text editors Confirm that the Legacy TinyMCE editor is no longer present Confirm that you can move the top editor down the list Open the user menu > Prefences page Open the Editor preferences Confirm that your preference is now set to the Default editor
    • 1
    • Team Hedgehog Sprint 2.2

      Time to remove the legacy TinyMCE editor from core!

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Meirza Meirza
            Ilya Tregubov Ilya Tregubov
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 5 hours, 15 minutes
                5h 15m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.