Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77368

Remove left over console debugging code in file upload module

    XMLWordPrintable

Details

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • Hide
      1. Log in as admin
      2. Open browser developer console
      3. Navigate to_Private files_ from user menu
      4. Drag and drop a file into the file manager
      5. Confirm that no debugging of DOM elements appears in console
      Show
      Log in as admin Open browser developer console Navigate to_Private files_ from user menu Drag and drop a file into the file manager Confirm that no debugging of DOM elements appears in console

    Description

      I can see this comes from Andrew's general comment in MDL-70947 https://tracker.moodle.org/browse/MDL-70947?focusedCommentId=845609&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-845609 - however it seems clear that this is merely an example, as it makes no sense to implement this in production code but was mistakenly taken as instruction

      This was actually questioned during integration https://tracker.moodle.org/browse/MDL-70947?focusedCommentId=853187&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-853187

      Unless there is a genuine purpose for logging random DOM elements to the console, it should be removed - ping huongn@moodle.com, maybe you remember more?

      Attachments

        Issue Links

          Activity

            People

              pholden Paul Holden
              pholden Paul Holden
              Huong Nguyen Huong Nguyen
              Andrew Lyons Andrew Lyons
              Kim Jared Lucas Kim Jared Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 50 minutes
                  50m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.