Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77391

Followup to MDL-77147 (Woefully inefficient query in admin/qtypes.php)

XMLWordPrintable

    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • MDL-77391-m401
    • Hide
      1. Ideally, before this is integrated, go to admin/qtypes.php, and screen-grab all the numbers.
      2. Then, with the new code in place visit Admin -> Plugins -> Question types -> Manage question types (admin/qtypes.php).
      3. Verify that the page displays with no errors.
      4. If you were able to get a 'before' screen-grab, Verify that the numbers in the 'No. questions' column are the same.
      Show
      Ideally, before this is integrated, go to admin/qtypes.php, and screen-grab all the numbers. Then, with the new code in place visit Admin -> Plugins -> Question types -> Manage question types (admin/qtypes.php). Verify that the page displays with no errors. If you were able to get a 'before' screen-grab, Verify that the numbers in the 'No. questions' column are the same.

      timhunt significantly improved this query in MDL-77147, but further evaluation identified that another significant jump in performance was possible. The new version was then tested by Tim with exciting, real world benefits:

      We downgraded the DB size on our test Moodle instance to save money, and now 'my' version of the query ... well actually, there is a lot of variation, but in some cases it was taking ~75 seconds, and at other times ~12. Your version of the query seems to take ~5 or ~2 seconds (even with the join on question_bank_entries added back). So, probably worth another issue here.

            jrchamp Jonathan Champ
            jrchamp Jonathan Champ
            Anupama Sarjoshi Anupama Sarjoshi
            Tim Hunt Tim Hunt
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 31 minutes
                31m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.