[MDL-77461] Some behat steps fetch course id incorrectly - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9.19, 3.11.12, 4.0.6, 4.1.1
Fix Version/s: 3.9.20, 3.11.13, 4.0.7, 4.1.2
Component/s: Automated functional tests (behat)
Labels:

Affected Branches:
MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE
Fixed Branches:
MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE
Pull from Repository:
https://github.com/andrewnicols/moodle.git
Pull 3.9 Branch:
~~MDL-77461~~-39
Pull 3.9 Diff URL:
https://github.com/andrewnicols/moodle/compare/9ebd08c452...MDL-77461-39
Pull 3.11 Branch:
~~MDL-77461~~-311
Pull 3.11 Diff URL:
https://github.com/andrewnicols/moodle/compare/65731963bc...MDL-77461-311
Pull 4.0 Branch:
~~MDL-77461~~-400
Pull 4.0 Diff URL:
https://github.com/andrewnicols/moodle/compare/6458658400...MDL-77461-400
Pull 4.1 Branch:
~~MDL-77461~~-401
Pull 4.1 Diff URL:
https://github.com/andrewnicols/moodle/compare/a31f5830bd...MDL-77461-401
Pull Master Branch:
~~MDL-77461~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/9ee4f8db8b...MDL-77461-master
Testing Instructions:
Hide

CI will test this.

You can also check that there are no more instances of this nature:

git grep 'DB->get_record.*course' | grep behat

Note: There may be other similar issues. I haven't checked every usage of every helper. This issue is blocking two issues in the queue so better to get this one and fix others as we discover them.
Show
CI will test this. You can also check that there are no more instances of this nature: git grep 'DB->get_record.*course' | grep behat Note: There may be other similar issues. I haven't checked every usage of every helper. This issue is blocking two issues in the queue so better to get this one and fix others as we discover them.

Description

We have a couple of behat steps which are fetching course ids using a $DB->get_records() call, which only checks the full name.

We should use $this->get_course_id() which allows us to fetch by name, short name, or idnumber.

Examples:

     * @Given /^I am on "(?P<coursefullname_string>(?:[^"]|\\")*)" course homepage$/

     * @Given I am on :coursefullname course homepage with editing mode :onoroff

Attachments

Issue Links

blocks

MDL-77014 Single activity course format should support multilang course titles

Closed

MDL-77141 Gradebook: user report should not display & in coursename as &

Closed

Activity

People

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Simey Lameze

Integrator:: Jake Dallimore

Tester:: CiBoT

Participants:: Andrew Lyons, CiBoT, Jake Dallimore, Simey Lameze

Component watchers:

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 02/Mar/23 11:05 AM

Updated:: 03/Mar/23 12:01 PM

Resolved:: 03/Mar/23 12:01 PM

Fix Release Date:: 13/Mar/23

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

57m