Loading...

XML

Word

Printable

Affected Branches:
MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE
Fixed Branches:
MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE
Pull from Repository:
https://github.com/andrewnicols/moodle.git
Pull 4.1 Branch:
~~MDL-77461~~-401
Pull 4.1 Diff URL:
https://github.com/andrewnicols/moodle/compare/a31f5830bd...MDL-77461-401
Pull Main Branch:
~~MDL-77461~~-master
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/9ee4f8db8b...MDL-77461-master
Testing Instructions:
Hide

CI will test this.

You can also check that there are no more instances of this nature:

git grep 'DB->get_record.*course' | grep behat

Note: There may be other similar issues. I haven't checked every usage of every helper. This issue is blocking two issues in the queue so better to get this one and fix others as we discover them.
Show
CI will test this. You can also check that there are no more instances of this nature: git grep 'DB->get_record.*course' | grep behat Note: There may be other similar issues. I haven't checked every usage of every helper. This issue is blocking two issues in the queue so better to get this one and fix others as we discover them.

We have a couple of behat steps which are fetching course ids using a $DB->get_records() call, which only checks the full name.

We should use $this->get_course_id() which allows us to fetch by name, short name, or idnumber.

Examples:

     * @Given /^I am on "(?P<coursefullname_string>(?:[^"]|\\")*)" course homepage$/

     * @Given I am on :coursefullname course homepage with editing mode :onoroff

blocks

MDL-77014 Single activity course format should support multilang course titles

MDL-77141 Gradebook: user report should not display & in coursename as &

Estimated:

Not Specified

Remaining:

Logged:

57m