Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 3.9.23, 3.11.16, 4.0.10, 4.1.5, 4.2.2
Affects Version/s: 3.9.22
Component/s: Filters
Labels:
- ci
- release_notes

Affected Branches:
MOODLE_39_STABLE
Fixed Branches:
MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE
Pull from Repository:
https://github.com/skodak/moodle.git
Pull 4.1 Branch:
~~MDL-77525~~/401
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...skodak:moodle:MDL-77525/401
Pull Main Branch:
~~MDL-77525~~/master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...skodak:moodle:MDL-77525/master
Testing Instructions:
Hide

Run automated tests

Example change needed for multilang2: https://github.com/iarenaza/moodle-filter_multilang2/compare/master...skodak:moodle-filter_multilang2:MDL-77525
Show
Run automated tests Example change needed for multilang2: https://github.com/iarenaza/moodle-filter_multilang2/compare/master...skodak:moodle-filter_multilang2:MDL-77525

The idea is to allow filters to alter the text at different stages in format_text():

before format conversion
before cleaning
after cleaning (current)

The format_string() would use separate stage because the expected results may be different.

The problem here will be backwards compatibility, we will have to probably create 4 new methods in filter base class and supply backwards compatible setup.

Also the UI might be a bit confusing because the order of execution will be nontrivial - each filter will be able to run text filtering in all 3 phases, string filtering will be in one separate stage.

Performance cost should be negligible.

This can be also discussed at:

https://moodle.org/mod/forum/discuss.php?d=447802

caused a regression

MDL-79360 broken nolink tag support in text filtering

Closed

has a non-specific relationship to

MDL-76743 Content processing and User trust

Open

MDL-32114 Characters converted to HTML entities in the re-edited Markdown text field

Closed

has to be done before

MDL-78505 Markdown text format ignores $options['noclean'] and fix for mangling of Markdown in editors

Closed

Assignee:: Petr Skoda

Reporter:: Petr Skoda

Peer reviewer:: Jordi Pujol-Ahulló

Integrator:: Ilya Tregubov

Tester:: CiBoT

Participants:: CiBoT, Ilya Tregubov, Jordi Pujol-Ahulló, Petr Skoda, Tilman Schieber

Votes:: 3 Vote for this issue

Watchers:: 13 Start watching this issue

Created:: 05/Mar/23 7:33 PM

Updated:: 20/Feb/24 11:27 PM

Resolved:: 23/Jun/23 4:11 PM

Estimated:

Remaining:

Logged:

40m

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify