Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77530

Checks in the tool_task incorrectly set id and action_link in a pointless way

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 4.0.6, 4.1.1, 4.2
    • 4.0.7, 4.1.2
    • Tasks

    Description

      This is just a bug due a change in the api for checks and these couple checks are using the wrong way which doesn't actually work.

      The correct way to set check metadata is viab methods:

      get_id(), get_name(), get_action_link()

      The incorrect way to do this was via properties in a version of the api which never landed:

      $this->id = 'foo', $this->name = 'blah'.

       

      Split from MDL-77336

      Attachments

        1. 400.png
          400.png
          152 kB
        2. 401.png
          401.png
          155 kB
        3. master.png
          master.png
          162 kB

        Issue Links

          Activity

            People

              brendanheywood Brendan Heywood
              brendanheywood Brendan Heywood
              Kevin Pham Kevin Pham
              Andrew Lyons Andrew Lyons
              Ron Carl Alfon Yu Ron Carl Alfon Yu
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/Mar/23

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 19 minutes
                  19m