Loading...

XML

Word

Printable

Affected Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE
Fixed Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE
Pull from Repository:
https://github.com/brendanheywood/moodle
Pull 4.1 Branch:
~~MDL-77530~~-tool-task-checks-MOODLE_401_STABLE
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...brendanheywood:MDL-77530-tool-task-checks-MOODLE_401_STABLE
Pull Main Branch:
~~MDL-77530~~-tool-task-checks
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...brendanheywood:moodle:MDL-77530-tool-task-checks
Testing Instructions:
Hide

Visit this report /report/status/index.php

Confirm that the 'Cron running' check has a link to 'Tasks running now' in the Action column

Confirm that the 'Tasks max fail delay' check has a link to 'Task logs' in the Action column

Confirm that the 'Long running tasks' check has a link to 'Tasks running now' in the Action column (NOTE this is ONLY in 4.2)
Show
Visit this report /report/status/index.php Confirm that the 'Cron running' check has a link to 'Tasks running now' in the Action column Confirm that the 'Tasks max fail delay' check has a link to 'Task logs' in the Action column Confirm that the 'Long running tasks' check has a link to 'Tasks running now' in the Action column (NOTE this is ONLY in 4.2)

This is just a bug due a change in the api for checks and these couple checks are using the wrong way which doesn't actually work.

The correct way to set check metadata is viab methods:

get_id(), get_name(), get_action_link()

The incorrect way to do this was via properties in a version of the api which never landed:

$this->id = 'foo', $this->name = 'blah'.

has been marked as being related by

MDL-77336 PHP 8.2: Dynamic Properties are deprecated for admin

is a regression caused by

MDL-72775 Add a new status check for the cron task api to watch very long running tasks

Participants:: Andrew Lyons, Brendan Heywood, CiBoT, Kevin Pham, Ron Carl Alfon Yu

Estimated:

Not Specified

Remaining:

Logged:

19m