[MDL-77533] Loading an unknown customfield handler produced a PHP type error - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 4.0.6
Fix Version/s: 4.0.7, 4.1.2
Component/s: General, Libraries
Labels:
- ci
- triaged

Affected Branches:
MOODLE_400_STABLE
Fixed Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE
Pull from Repository:
https://github.com/paulholden/moodle
Pull 4.0 Branch:
~~MDL-77533~~-400
Pull 4.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_400_STABLE...paulholden:MDL-77533-400
Pull 4.1 Branch:
~~MDL-77533~~-401
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...paulholden:MDL-77533-401
Pull Master Branch:
~~MDL-77533~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-77533
Testing Instructions:
1. Covered by automated tests (PHPUnit)

Description

Found while looking at MDL-77532

If the customfield handler isn't present, then we receive an obscure PHP type error:

Fatal error: Uncaught TypeError: stripos(): Argument #1 ($haystack) must be of type string, stdClass given in /opt/moodle/master/src/lib/setuplib.php:580 Stack trace: #0 /opt/moodle/master/src/lib/setuplib.php(580): stripos() #1 /opt/moodle/master/src/lib/setuplib.php(363): get_exception_info() #2 [internal function]: default_exception_handler() #3 {main} thrown in /opt/moodle/master/src/lib/setuplib.php on line 580

Instead of the intended exception (once fixed):

Because the arguments passed to the exception constructor are misordered

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Screenshot 2023-03-04 at 12-43-03 Screenshot.png
29 kB
06/Mar/23 5:09 PM
Screenshot 2023-03-04 at 12-43-23 Error.png
102 kB
06/Mar/23 5:09 PM

Issue Links

Discovered while testing

MDL-77532 Include custom fields in cohort report entity

Tested

Activity

People

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: David Matamoros

Integrator:: Jun Pataleta

Tester:: CiBoT

Participants:: CiBoT, David Matamoros, Jun Pataleta, Paul Holden

Component watchers:: Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 06/Mar/23 5:05 PM

Updated:: 10/Mar/23 11:16 PM

Resolved:: 10/Mar/23 11:16 PM

Fix Release Date:: 13/Mar/23

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

35m